Bug 217798 - math/geogebra: update to 5.0.341.0
Summary: math/geogebra: update to 5.0.341.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Nikolai Lifanov
URL:
Keywords: easy, patch, patch-ready
Depends on:
Blocks:
 
Reported: 2017-03-15 08:03 UTC by Zsolt Udvari
Modified: 2017-03-17 15:29 UTC (History)
1 user (show)

See Also:
uzsolt: maintainer-feedback+

Attachments
patch (1.49 KB, patch)
2017-03-15 08:03 UTC, Zsolt Udvari 		uzsolt: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zsolt Udvari freebsd_committer freebsd_triage 2017-03-15 08:03:02 UTC 
Created attachment 180838 [details]
patch

Simple update to 5.0.341.0
Poudriere & portlint passed.

Changelog: https://wiki.geogebra.org/en/Reference:Changelog_5.0
Comment 1 Nikolai Lifanov freebsd_committer freebsd_triage 2017-03-17 14:16:12 UTC 
Is removal of JAVA_RUN intentional?
Comment 2 Zsolt Udvari freebsd_committer freebsd_triage 2017-03-17 14:42:35 UTC 
(In reply to Nikolai Lifanov from comment #1)
Yes, it seems it works without jre. The openjdk8 is enough.

Did I think something wrong?
Comment 3 Zsolt Udvari freebsd_committer freebsd_triage 2017-03-17 15:14:49 UTC 
Hm, I check the bsd.java.mk:
As I see it sets the JAVA_RUN to jre if JAVA_{EXTRACT,BUILD,RUN} are undefined: https://svnweb.freebsd.org/ports/head/Mk/bsd.java.mk?revision=413938&view=markup#l258

I thought the JAVA_RUN=jre adds the openjdk-jre dependency and I checked 'geogebra' works without jre.

But I think the deleting of JAVA_RUN line in geogebra/Makefile doesn't change anything because in this case it's automatically defined (in bsd.java.mk).

So I think the 'JAVA_RUN'-line can be removed but if it should stay then it can stay.
Comment 4 Nikolai Lifanov freebsd_committer freebsd_triage 2017-03-17 15:28:11 UTC 
Thanks for clarification! I just wanted to ask whether this was a stray change or whether it was intentional.
Comment 5 commit-hook freebsd_committer freebsd_triage 2017-03-17 15:29:33 UTC 
A commit references this bug:

Author: lifanov
Date: Fri Mar 17 15:28:57 UTC 2017
New revision: 436341
URL: https://svnweb.freebsd.org/changeset/ports/436341

Log:
  update math/geogebra to 5.0.341.0

  PR:		217798
  Submitted by:	Zsolt Udvari <udvzsolt@gmail.com> (maintainer)

Changes:
  head/math/geogebra/Makefile
  head/math/geogebra/distinfo
Comment 6 Nikolai Lifanov freebsd_committer freebsd_triage 2017-03-17 15:29:56 UTC 
Committed, thanks!