Bug 217916 - [patch] irc/irssi-xmpp: Fix build with irssi 1.0
Summary: [patch] irc/irssi-xmpp: Fix build with irssi 1.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Philippe Audeoud
URL:
Keywords: patch
: 218328 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-03-19 10:22 UTC by Thibault Jouan
Modified: 2017-06-06 15:05 UTC (History)
4 users (show)

See Also:
bugzilla: maintainer-feedback? (jadawin)

Attachments
Fix irc/irssi-xmpp build with irssi 1 patch (1.81 KB, patch)
2017-03-19 10:22 UTC, Thibault Jouan 		no flags Details | Diff
svn diff for irc/irssi-xmpp (1.94 KB, patch)
2017-03-19 19:58 UTC, Bernard Spil 		brnrd: maintainer-approval?
Details | Diff
The same, but with PORTREVISION (2.28 KB, patch)
2017-04-20 17:09 UTC, Anonymized Account 		no flags Details | Diff
portlint -AC (283 bytes, text/plain)
2017-04-20 17:09 UTC, Anonymized Account 		no flags Details
poudriere testport (46.20 KB, text/plain)
2017-04-20 17:10 UTC, Anonymized Account 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thibault Jouan 2017-03-19 10:22:29 UTC 
Created attachment 180957 [details]
Fix irc/irssi-xmpp build with irssi 1 patch

In bug 215829 a patch was added to support irssi 1, but it was later
removed as irssi was downgraded to 0.8.

But irssi was recently updated (bug 217348), and we now need the patch
for 1.0 again. The attached patch just restore the original patch.

FYI, upstream also made a change to now support only irssi 1, but no
new release have been made yet.
Comment 1 Bernard Spil freebsd_committer freebsd_triage 2017-03-19 19:58:10 UTC 
Created attachment 180969 [details]
svn diff for irc/irssi-xmpp

re-roll patch as svn diff
Comment 2 Anonymized Account freebsd_committer freebsd_triage 2017-04-20 17:09:39 UTC 
Created attachment 181950 [details]
The same, but with PORTREVISION
Comment 3 Anonymized Account freebsd_committer freebsd_triage 2017-04-20 17:09:58 UTC 
Created attachment 181951 [details]
portlint -AC
Comment 4 Anonymized Account freebsd_committer freebsd_triage 2017-04-20 17:10:14 UTC 
Created attachment 181952 [details]
poudriere testport
Comment 5 Anonymized Account freebsd_committer freebsd_triage 2017-04-20 17:10:32 UTC 
Duplicate of https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218328
Comment 6 Bernard Spil freebsd_committer freebsd_triage 2017-04-20 18:56:07 UTC 
*** Bug 218328 has been marked as a duplicate of this bug. ***
Comment 7 commit-hook freebsd_committer freebsd_triage 2017-04-20 18:58:12 UTC 
A commit references this bug:

Author: brnrd
Date: Thu Apr 20 18:57:34 UTC 2017
New revision: 438990
URL: https://svnweb.freebsd.org/changeset/ports/438990

Log:
  irc/irssi-xmpp: Fix build with irssi 1.0

   - Add patch from upstream

  PR:		217916, 218328
  Submitted by:	Thibault Jouan <tj+freebsd_ports@a13.fr>
  Approved by:	maintainer timeout
  Obtained from:	https://github.com/cdidier/irssi-xmpp/issues/18

Changes:
  head/irc/irssi-xmpp/files/
  head/irc/irssi-xmpp/files/patch-src_core_xmpp-servers.c
Comment 8 commit-hook freebsd_committer freebsd_triage 2017-06-06 15:05:34 UTC 
A commit references this bug:

Author: ler
Date: Tue Jun  6 15:05:16 UTC 2017
New revision: 442777
URL: https://svnweb.freebsd.org/changeset/ports/442777

Log:
  MFH: r438990 r439548

  Approved by: ports-secteam (blanket)

  irc/irssi-xmpp: Fix build with irssi 1.0

   - Add patch from upstream

  PR:		217916, 218328
  Submitted by:	Thibault Jouan <tj+freebsd_ports@a13.fr>
  Approved by:	maintainer timeout
  Obtained from:	https://github.com/cdidier/irssi-xmpp/issues/18

  irc/irssi-xmpp: Improve regex conformance

  PR:		218603
  Submitted by:	Kyle Evans <bsdports@kyle-evans.net>
  Approved by:	 jadwin (maintainer timeout), rene (mentor)
  Differential Revision:	https://reviews.freebsd.org/D10524

Changes:
_U  branches/2017Q2/
  branches/2017Q2/irc/irssi-xmpp/Makefile
  branches/2017Q2/irc/irssi-xmpp/files/