Created attachment 181105 [details] Unified diff Fix task affinity (The reinplace for cpuset_setaffinity should not have been removed as it was not one of the patches incorporated upstream). The MYSQL and GTK2 options were not functioning properly when off. If mysql and gtk2 were installed during configure phase, slurm would build sview and mysql support whether or not the options were selected. Poudriere will not catch this sort of problem. I tested by installing with all options enabled so that all possible dependencies would be installed, and then rebuilding with all options off. No QA warnings in either case now. I am also suggesting that we drop files/slurm.conf.sample, as it is outdated. This patch contains some suggested reinplace commands to touch up the example file in the dist and install that instead. Patch in /usr/bin/mail as default so that it will work out of the box instead of requiring an override in slurm.conf. Silence a QA warning about liblz4.
A commit references this bug: Author: jrm Date: Fri Mar 24 18:52:29 UTC 2017 New revision: 436851 URL: https://svnweb.freebsd.org/changeset/ports/436851 Log: sysutils/slurm-wlm: Fix task affinity, mysql and gtk2 options, update default slurm.conf, silence QA warning about liblz4, patch to make /usr/bin/mail the default. - Fix task affinity. The reinplace for cpuset_setaffinity should not have been removed as it was not one of the patches incorporated upstream. - The MYSQL and GTK2 options were not functioning properly when off. If mysql and gtk2 were installed during configure phase, slurm would build sview and mysql support whether or not the options were selected. Poudriere will not catch this sort of problem. I tested by installing with all options enabled so that all possible dependencies would be installed, and then rebuilding with all options off. No QA warnings in either case now. - Remove the outdated files/slurm.conf.sample. Install a patched version of the included slurm.conf file instead. - Patch to make /usr/bin/mail the default, so that mail will work out of the box instead of requiring an override in slurm.conf. - Silence a QA warning about liblz4 by adding archivers/liblz4 to LIB_DEPENDS. PR: 218044 Submitted by: bacon4000@gmail.com Approved by: swills (mentor, implicit) Changes: head/sysutils/slurm-wlm/Makefile head/sysutils/slurm-wlm/files/slurm.conf.sample head/sysutils/slurm-wlm/pkg-plist
Committed. Thanks.