Bug 218193 - [PATCH] ntp docs missing in OptionalObsoleteFiles.inc
Summary: [PATCH] ntp docs missing in OptionalObsoleteFiles.inc
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: misc (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: Ed Maste
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2017-03-28 19:53 UTC by Bernard Spil
Modified: 2021-09-22 23:17 UTC (History)
2 users (show)

See Also:

Attachments
git diff for tools/build/mk/OptionalObsoleteFiles.inc (11.68 KB, patch)
2017-03-28 19:53 UTC, Bernard Spil 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bernard Spil freebsd_committer freebsd_triage 2017-03-28 19:53:05 UTC 
Created attachment 181279 [details]
git diff for tools/build/mk/OptionalObsoleteFiles.inc

The list of files for WITH_NTP is incomplete in OptionalObsoleteFiles.inc.

Attached a patch adding the additional files I've found installed in /usr/share/doc
Comment 1 commit-hook freebsd_committer freebsd_triage 2017-09-15 00:55:32 UTC 
A commit references this bug:

Author: emaste
Date: Fri Sep 15 00:54:37 UTC 2017
New revision: 323607
URL: https://svnweb.freebsd.org/changeset/base/323607

Log:
  Update OptionalObsoleteFiles.inc with NTP docs

  The list of files for MK_NTP was incomplete.

  PR:		218193
  Submitted by:	brnrd
  MFC after:	1 week

Changes:
  head/tools/build/mk/OptionalObsoleteFiles.inc
Comment 2 Ed Maste freebsd_committer freebsd_triage 2017-09-15 00:55:43 UTC 
Bernard, do you know what the status in stable/11 and stable/10 is? (I.e., do we have the same NTP version there?)
Comment 3 Bernard Spil freebsd_committer freebsd_triage 2017-09-16 19:26:42 UTC 
Hi Ed,

All at the same version it seems

/stable/10/contrib/ntp/ChangeLog ntp 4.2.8p10
/stable/11/contrib/ntp/ChangeLog ntp 4.2.8p10
/head/contrib/ntp/ChangeLog ntp 4.2.8p10

Cheers, Bernard.
Comment 4 Eitan Adler freebsd_committer freebsd_triage 2018-05-23 10:27:23 UTC 
batch change of PRs untouched in 2018 marked "in progress" back to open.
Comment 5 Piotr Pawel Stefaniak freebsd_committer freebsd_triage 2021-09-22 21:30:18 UTC 
Ed, do you think this PR can be closed now? Unless we're waiting for 11 to be EOL'd.
Comment 6 commit-hook freebsd_committer freebsd_triage 2021-09-22 23:16:29 UTC 
A commit in branch stable/11 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=59a0ec578693887386ed787d2ee34d37f346eb80

commit 59a0ec578693887386ed787d2ee34d37f346eb80
Author:     Ed Maste <emaste@FreeBSD.org>
AuthorDate: 2017-09-15 00:54:37 +0000
Commit:     Ed Maste <emaste@FreeBSD.org>
CommitDate: 2021-09-22 23:11:09 +0000

    Update OptionalObsoleteFiles.inc with NTP docs

    The list of files for MK_NTP was incomplete.

    PR:             218193
    Submitted by:   brnrd
    MFC after:      1 week

    (cherry picked from commit 4154e70ea8dc0ac0d1639374ea3bc7b6c9744b9f)

 tools/build/mk/OptionalObsoleteFiles.inc | 203 +++++++++++++++++++++++++++++++
 1 file changed, 203 insertions(+)
Comment 7 Ed Maste freebsd_committer freebsd_triage 2021-09-22 23:17:37 UTC 
(In reply to Piotr Pawel Stefaniak from comment #5)

It seems I just missed the MFC. stable/11 will indeed be EOL in a couple of days, but instead I just belatedly cherry picked the change. Thanks for the ping.