Bug 218863 - [new feature] www/tomcat85: Add options menu
Summary: [new feature] www/tomcat85: Add options menu
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Only Me
Assignee: Larry Rosenman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-25 01:36 UTC by fsbruva
Modified: 2017-05-06 15:23 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (vvd)


Attachments
Unified diff for Makefile and pkg-plist (70.92 KB, patch)
2017-04-25 01:36 UTC, fsbruva
no flags Details | Diff
Added options and update tomcat85 version from 8.5.13 to 8.5.14 (70.27 KB, patch)
2017-05-06 14:40 UTC, Vladimir Druzenko
vvd: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description fsbruva 2017-04-25 01:36:09 UTC
Created attachment 182067 [details]
Unified diff for Makefile and pkg-plist

ports r439346
Based on Apache Tomcat documentation guidance, the default web applications have varying degrees of risk. The attached patch will permit users to select which of the web applications should be installed.
Comment 1 Vladimir Druzenko freebsd_committer freebsd_triage 2017-04-30 23:00:03 UTC
Will to test it soon…
Comment 2 Vladimir Druzenko freebsd_committer freebsd_triage 2017-05-06 13:49:27 UTC
Patch with windoze ^M (0x0D) in each line - are you serious?
And you replaced all TABs on SPACEs - patch can't apply patch to Makefile:
[vvd@host ~/ports/www/tomcat85]$ patch < patch
Hmm...  Looks like a unified diff to me...
The text leading up to this was:
--------------------------
|Index: Makefile
|===================================================================
|--- Makefile    (revision 439346)
|+++ Makefile    (working copy)
--------------------------
Patching file Makefile using Plan A...
Hunk #1 failed at 31.
Hunk #2 failed at 70.
2 out of 2 hunks failed--saving rejects to Makefile.rej
Hmm...  The next patch looks like a unified diff to me...
The text leading up to this was:
--------------------------
|Index: pkg-plist
|===================================================================
|--- pkg-plist   (revision 439346)
|+++ pkg-plist   (working copy)
--------------------------
Patching file pkg-plist using Plan A...
Hunk #1 succeeded at 63.
done
Comment 3 Vladimir Druzenko freebsd_committer freebsd_triage 2017-05-06 14:40:20 UTC
Created attachment 182334 [details]
Added options and update tomcat85 version from 8.5.13 to 8.5.14
Comment 4 Larry Rosenman freebsd_committer freebsd_triage 2017-05-06 15:22:56 UTC
committed thanks
Comment 5 commit-hook freebsd_committer freebsd_triage 2017-05-06 15:23:33 UTC
A commit references this bug:

Author: ler
Date: Sat May  6 15:22:41 UTC 2017
New revision: 440274
URL: https://svnweb.freebsd.org/changeset/ports/440274

Log:
  www/tomcat85: upgrade to 8.5.14 and ads options menu

  PR:		218863
  Submitted by:	<fsbruva@yahoo.com>
  Approved by:	adamw (mentor, implicit), vvd@unislabs.com (maintainer)

Changes:
  head/www/tomcat85/Makefile
  head/www/tomcat85/distinfo
  head/www/tomcat85/pkg-plist