Bug 218868 - sysutils/logstash: Current(v2.3.2) is unmaintained - Update to latest version (v2.4.1)
Summary: sysutils/logstash: Current(v2.3.2) is unmaintained - Update to latest version...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Matthew Seaman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-25 09:43 UTC by Dani I.
Modified: 2017-05-24 17:29 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (enrico.m.crisostomo)
tj: maintainer-feedback-
matthew: maintainer-feedback-


Attachments
Update to 2.4.1 (738.12 KB, patch)
2017-05-09 20:41 UTC, Matthew Seaman
matthew: maintainer-approval?
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dani I. 2017-04-25 09:43:02 UTC
The current version(v2.3.2) available for FreeBSD is not beeing maintained anymore, since the release of version 2.4.x.

See here: https://www.elastic.co/support/eol
Latest Release: https://www.elastic.co/downloads/past-releases/logstash-2-4-1

Available version @ ports: 2.3.2
Latest version @ upstream: 2.4.1

Logstash 2.4.x is compatible with Elasticsearch5, while 2.3.x isn't. So it would be cool to have 2.4.x, instead of beeing forced to update to Logstash5.

Thanks for taking a look at it.
Comment 1 Matthew Seaman freebsd_committer freebsd_triage 2017-05-09 09:46:29 UTC
Why are you asking me for maintainer feedback?  I'm not the maintainer.

Hmmm... Is there any specific reason to have logstash-2.4.1 in the ports when
we already have logstash-5.3.0?  (sysutils/logstash5)
Comment 2 Dani I. 2017-05-09 10:03:11 UTC
(In reply to Matthew Seaman from comment #1)
Sorry for that. I saw that you have commited the last updates and since i haven't heard anything from the maintainer for over 2 weeks i tought i'll add you and tj(Maintainer of logstash5).

There are multiple reasons. If you have a ELK Stack and 100+ servers running logstash, it isn't such a fast thing to update to a new major release. 2.4.x will be maintained until 02.2018 [1] and is the last & latest release of the 2.x series. I think we aren't the only ones who still need 2.x to run, until we have everything ready for 5.x. And there were multiple needed and "critical" bugfixes made for 2.4.x over 2.3.2, which we would really love to see beeing pushed to the portstree.

With 2.4.x there is also the possibility to upgrade to elasticsearch5/kibana5 without having to update all logstash instances too[2]. So a step by step update would be possible.

I hope you understand our request and sorry again if i shouldn't have added you.

[1] https://www.elastic.co/support/eol
[2] https://www.elastic.co/support/matrix#show_compatibility
Comment 3 Matthew Seaman freebsd_committer freebsd_triage 2017-05-09 10:26:39 UTC
(In reply to Dani from comment #2)
No worries.  I don't mind being pinged about this, it's just a slightly odd way you've chosen to do it.

You make a good point about the upgrade path for large installations.

The next step here would be to generate some patches to update the port to 2.4.1
-- that way the maintainer can either approve them, or we can wait for the maintainer timeout and then apply them.

Is that something you feel you could have a go at?  If not I'll try and take a look this evening.
Comment 4 Dani I. 2017-05-09 13:07:35 UTC
Cool, thanks! If i'll add you too CC-List next time, would that be better? :)

Yeah i think it would be really nice to have 2.4.x available. I can take a look at it but i'm quite busy at the moment. So it it's going to be about tomorrow, until i find time for it. So if you have a chance feel free to, else i'll try to take a look at it asap.
Comment 5 Tom Judge freebsd_committer freebsd_triage 2017-05-09 14:49:57 UTC
I'm not interested in maintaining the port for this legacy version.
Comment 6 Matthew Seaman freebsd_committer freebsd_triage 2017-05-09 20:41:04 UTC
Created attachment 182452 [details]
Update to 2.4.1

This just bumps the version number, updates distinfo and fixes the pkg-plist.

Needs:

   * testing
   * There are several copies of libjffi-1.2.so installed 
     - most of these are for foreign architectures.  Are they really needed?
     - they probably need stripping

Also it seems the FreeBSD binary is  always x86_64-FreeBSD/libjffi-1.2.so even on 32-bit Intel architectures.
Comment 7 Dani I. 2017-05-10 08:41:10 UTC
(In reply to Matthew Seaman from comment #6)

Thanks for doing the update! We have applied the changes locally and have sucessfully built for FreeBSD 10.3. We've installed it on a test server and until now everything looks very fine and logstash is running smooth. We'll report if we see any problems.
Comment 8 commit-hook freebsd_committer freebsd_triage 2017-05-24 17:28:29 UTC
A commit references this bug:

Author: matthew
Date: Wed May 24 17:28:22 UTC 2017
New revision: 441610
URL: https://svnweb.freebsd.org/changeset/ports/441610

Log:
  Upgrade to 2.4.1

  PR:		218868
  Reported by:	i.dani@outlook.com
  Approved by:	maintainer timeout (14 days)

Changes:
  head/sysutils/logstash/Makefile
  head/sysutils/logstash/distinfo
  head/sysutils/logstash/pkg-plist
Comment 9 Matthew Seaman freebsd_committer freebsd_triage 2017-05-24 17:29:13 UTC
Committed, thanks!