Bug 219264 - x11/libwacom: install the profiles of tablets
Summary: x11/libwacom: install the profiles of tablets
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-x11 (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-13 21:39 UTC by Henry Hu
Modified: 2018-05-20 14:52 UTC (History)
2 users (show)

See Also:
rezny: maintainer-feedback+

Attachments
patch to install profiles (4.50 KB, patch)
2017-05-13 21:39 UTC, Henry Hu 		no flags Details | Diff
fix the replacement command (4.50 KB, patch)
2017-05-13 21:40 UTC, Henry Hu 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Henry Hu 2017-05-13 21:39:15 UTC 
Created attachment 182575 [details]
patch to install profiles

Due to a linux-only command in the Makefiles (find -printf), libwacom port is not correctly finding and installing the profiles and tablets. This defeats its main purpose: supplying metadata about Wacome tablets. This patch fixes this.

The attached patch replaces
    find ... -printf "%P\n"
with
    find ... -print0 | xargs -0 basename
which works on FreeBSD.

pkg-plist is updated to include the newly installed profiles.
Comment 1 Henry Hu 2017-05-13 21:40:36 UTC 
Created attachment 182576 [details]
fix the replacement command
Comment 2 Matthew Rezny freebsd_committer freebsd_triage 2017-08-06 09:37:17 UTC 
Thank you for submitting this correction.
Comment 3 commit-hook freebsd_committer freebsd_triage 2018-05-20 14:42:26 UTC 
A commit references this bug:

Author: zeising
Date: Sun May 20 14:41:44 UTC 2018
New revision: 470461
URL: https://svnweb.freebsd.org/changeset/ports/470461

Log:
  x11/libwacom: install the profiles of tablets

  Due to a linux only command in the makefile libwacom isn't finding and
  installing tablet profiles.  Fix the command to work on FreeBSD and thus
  install tablet profiles.

  PR:		219264
  Submitted by:	Henry Hu

Changes:
  head/x11/libwacom/Makefile
  head/x11/libwacom/pkg-plist
Comment 4 Niclas Zeising freebsd_committer freebsd_triage 2018-05-20 14:52:12 UTC 
Fixed, thanks for the report!