Bug 219515 - bsdinstall adds extra ifconfig lines to rc.conf on dhcp lease failure
Summary: bsdinstall adds extra ifconfig lines to rc.conf on dhcp lease failure
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: 11.0-STABLE
Hardware: Any Any
: --- Affects Only Me
Assignee: Ed Maste
URL: https://reviews.freebsd.org/D11967
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-25 01:49 UTC by Mason Loring Bliss
Modified: 2018-09-05 13:32 UTC (History)
1 user (show)

See Also:
emaste: mfc-stable11?
emaste: mfc-stable10-
emaste: mfc-stable9-

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mason Loring Bliss freebsd_triage 2017-05-25 01:49:03 UTC 
I just installed a system using FreeBSD-11.1-PRERELEASE-amd64-20170519-r318507-memstick.img. I had the wrong NIC plugged in without realizing it, so I failed to acquire a DHCP lease twice before looking. After install, I'm noticing that /etc/rc.conf has one ifconfig_re0="DHCP" line per attempt, so three in total:

ifconfig_re0="DHCP"
ifconfig_re0="DHCP"
ifconfig_re0="DHCP"
Comment 1 Mason Loring Bliss freebsd_triage 2017-08-10 19:27:02 UTC 
FreeBSD is better off this way. Sorry for the bother.
Comment 2 Ed Maste freebsd_committer freebsd_triage 2017-08-10 20:20:53 UTC 
Patch in review at https://reviews.freebsd.org/D11967
Comment 3 Ed Maste freebsd_committer freebsd_triage 2017-08-10 20:26:56 UTC 
Set flags to track MFC
Comment 4 commit-hook freebsd_committer freebsd_triage 2017-08-10 20:27:12 UTC 
A commit references this bug:

Author: emaste
Date: Thu Aug 10 20:26:08 UTC 2017
New revision: 322374
URL: https://svnweb.freebsd.org/changeset/base/322374

Log:
  bsdinstall: record DHCP config after obtaining lease

  Previously we added an ifconfig_$INTERFACE line to rc.conf for each
  unsuccessful DCHP attempt.

  PR:		219515
  Reviewed by:	allanjude
  MFC after:	1 month
  Sponsored by:	The FreeBSD Foundation
  Differential Revision:	https://reviews.freebsd.org/D11967

Changes:
  head/usr.sbin/bsdinstall/scripts/netconfig_ipv4
Comment 5 commit-hook freebsd_committer freebsd_triage 2017-09-09 00:33:37 UTC 
A commit references this bug:

Author: emaste
Date: Sat Sep  9 00:33:20 UTC 2017
New revision: 323336
URL: https://svnweb.freebsd.org/changeset/base/323336

Log:
  MFC r322374: bsdinstall: record DHCP config after obtaining lease

  Previously we added an ifconfig_$INTERFACE line to rc.conf for each
  unsuccessful DCHP attempt.

  PR:		219515
  Sponsored by:	The FreeBSD Foundation

Changes:
_U  stable/11/
  stable/11/usr.sbin/bsdinstall/scripts/netconfig_ipv4
Comment 6 commit-hook freebsd_committer freebsd_triage 2017-09-09 01:24:20 UTC 
A commit references this bug:

Author: emaste
Date: Sat Sep  9 01:23:30 UTC 2017
New revision: 323337
URL: https://svnweb.freebsd.org/changeset/base/323337

Log:
  MFC r322374: bsdinstall: record DHCP config after obtaining lease

  Previously we added an ifconfig_$INTERFACE line to rc.conf for each
  unsuccessful DCHP attempt.

  PR:		219515
  Approved by:	re (marius)
  Sponsored by:	The FreeBSD Foundation

Changes:
_U  stable/10/
  stable/10/usr.sbin/bsdinstall/scripts/netconfig_ipv4
Comment 7 Eitan Adler freebsd_committer freebsd_triage 2018-05-28 19:48:23 UTC 
batch change:

For bugs that match the following
-  Status Is In progress 
AND
- Untouched since 2018-01-01.
AND
- Affects Base System OR Documentation

DO:

Reset to open status.


Note:
I did a quick pass but if you are getting this email it might be worthwhile to double check to see if this bug ought to be closed.