Bug 219939 - databases/pecl-rrd: not compatible with php7
Summary: databases/pecl-rrd: not compatible with php7
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Florian Smeets
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-12 12:51 UTC by Stéphane D'Alu
Modified: 2017-09-07 14:37 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (flo)

Attachments
Patch that creates deprecated port + updates current (5.95 KB, patch)
2017-06-13 14:29 UTC, Daniel Ylitalo 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stéphane D'Alu 2017-06-12 12:51:12 UTC 
Current version of pecl-rrd (1.x) is not compatible with php7, need to upgrade to version 2.x 
(note that version 2.x is not backward compatible with php5)

https://pecl.php.net/package-changelog.php?package=rrd
Comment 1 Daniel Ylitalo 2017-06-13 14:29:32 UTC 
Created attachment 183448 [details]
Patch that creates deprecated port + updates current

Attaching patch that solves this the same way sunpoet did for pecl-memcached, pecl-apcu etc.

flo, you need to do this before applying the patch;
svn cp pecl-rrd pecl-rrd1
svn delete pecl-rrd1/files

Attached patch passes portlint -AC + poudriere testport for both 
databases/pecl-rrd
databases/pecl-rrd1

What it does is copying databases/pecl-rrd to databases/pecl-rrd1 and sets ignore with php 7.0 + 7.1

And then updates databases/pecl-rrd to latest and adds ignore for php 5.6

For databases/pecl-rrd to build you need to have DEFAULT_VERSIONS= php=7.0 or 7.1 just as for pecl-apcu and pecl-memcached

I also removed the patches that checks if one is using rrdtool >= 1.3.0 as to be able to have < 1.3.0 you need a ports tree from 2008.
Comment 2 commit-hook freebsd_committer freebsd_triage 2017-09-07 14:33:48 UTC 
A commit references this bug:

Author: jrm
Date: Thu Sep  7 14:32:29 UTC 2017
New revision: 449400
URL: https://svnweb.freebsd.org/changeset/ports/449400

Log:
  New port, databases/pecl-rrd1: Copied from databases/pecl-rrd, so that
  databases/pecl-rrd can be updated to version 2.0.1.  Separate ports are
  needed because databases/pecl-rrd does not support php 5.6 and
  databases/pecl-rrd1 does not support php 7.0 and 7.1.

  PR:		219939
  Submitted by:	daniel@blodan.se (maintainer)

Changes:
  head/databases/Makefile
  head/databases/pecl-rrd1/
  head/databases/pecl-rrd1/Makefile
  head/databases/pecl-rrd1/distinfo
  head/databases/pecl-rrd1/files/
Comment 3 commit-hook freebsd_committer freebsd_triage 2017-09-07 14:36:53 UTC 
A commit references this bug:

Author: jrm
Date: Thu Sep  7 14:35:47 UTC 2017
New revision: 449401
URL: https://svnweb.freebsd.org/changeset/ports/449401

Log:
  databases/pecl-rrd: Update to version 2.0.1 and limit php support to
  versions 7.0 and later.

  PR:		219939
  Submitted by:	daniel@blodan.se
  Approved by:	maintainer timeout

Changes:
  head/databases/pecl-rrd/Makefile
  head/databases/pecl-rrd/distinfo
  head/databases/pecl-rrd/files/patch-rrd.c