Bug 220247 - graphics/pfstools: [PATCH]fix qt option build
Summary: graphics/pfstools: [PATCH]fix qt option build
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Richard Gallamore
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2017-06-24 10:40 UTC by Jov
Modified: 2017-07-14 01:48 UTC (History)
2 users (show)

See Also:
fbsd: maintainer-feedback+

Attachments
pfstools_fix_qt.diff (434 bytes, patch)
2017-06-24 10:40 UTC, Jov 		no flags Details | Diff
Some additional patches (2.15 KB, patch)
2017-06-26 08:41 UTC, Iouri V. Ivliev 		fbsd: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jov 2017-06-24 10:40:23 UTC 
Created attachment 183760 [details]
pfstools_fix_qt.diff

Ports/r434380 rename moc-qt4 to moc which break pfstools when qt option on.
Comment 1 Iouri V. Ivliev 2017-06-26 08:35:42 UTC 
It's OK, thanks.
Comment 2 Iouri V. Ivliev 2017-06-26 08:41:59 UTC 
Created attachment 183798 [details]
Some additional patches
Comment 3 Iouri V. Ivliev 2017-06-26 08:49:06 UTC 
Comment on attachment 183760 [details]
pfstools_fix_qt.diff

maintainer-approval+
Comment 4 Richard Gallamore freebsd_committer freebsd_triage 2017-06-30 22:56:28 UTC 
(In reply to Iouri V. Ivliev from comment #3)
This will require a revision bump.
Comment 5 Richard Gallamore freebsd_committer freebsd_triage 2017-07-06 22:18:03 UTC 
(In reply to Iouri V. Ivliev from comment #1)
Why was post-install changed to post-stage?
Comment 6 commit-hook freebsd_committer freebsd_triage 2017-07-14 01:46:09 UTC 
A commit references this bug:

Author: ultima
Date: Fri Jul 14 01:45:43 UTC 2017
New revision: 445722
URL: https://svnweb.freebsd.org/changeset/ports/445722

Log:
  * Fix qt option build
  * Changed OCTAVE USES to option helper

  PR:		220247
  Submitted by:	Iouri V. Ivliev <fbsd@any.com.ru> (maintainer)
  Reported by:	Jov <amutu@amutu.com>
  Reviewed by:	lifanov (mentor), matthew (mentor), matt
  Approved by:	lifanov (mentor)
  Differential Revision:	https://reviews.freebsd.org/D11495

Changes:
  head/graphics/pfstools/Makefile
  head/graphics/pfstools/files/patch-src-filter-pfswb.cpp
  head/graphics/pfstools/files/patch-src-pfs-pfs.h
Comment 7 Richard Gallamore freebsd_committer freebsd_triage 2017-07-14 01:48:50 UTC 
Committed, thanks!