Bug 220320 - devel/flatbuffers: Update to 1.7.1
Summary: devel/flatbuffers: Update to 1.7.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Richard Gallamore
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-28 03:11 UTC by Yuri Victorovich
Modified: 2017-06-29 19:08 UTC (History)
1 user (show)

See Also:

Attachments
patch (931 bytes, patch)
2017-06-28 03:11 UTC, Yuri Victorovich 		yuri: maintainer-approval+
Details | Diff
patch (1.30 KB, patch)
2017-06-28 17:19 UTC, Yuri Victorovich 		yuri: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer freebsd_triage 2017-06-28 03:11:36 UTC 
Created attachment 183867 [details]
patch

Builds in poudriere.
Comment 1 Richard Gallamore freebsd_committer freebsd_triage 2017-06-28 17:09:05 UTC 
- According to [1] the USE_GITHUB and GH_* should be after USES.
- The CMAKE_ARGS doesn't need the +, please remove this.
- TEST_TARGET= test should suffice for the do-test: target.


[1] https://www.freebsd.org/doc/en/books/porters-handbook/porting-samplem.html#porting-samplem-order
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2017-06-28 17:19:16 UTC 
Created attachment 183890 [details]
patch

Updated the patch.
Comment 3 commit-hook freebsd_committer freebsd_triage 2017-06-29 18:12:26 UTC 
A commit references this bug:

Author: ultima
Date: Thu Jun 29 18:11:35 UTC 2017
New revision: 444655
URL: https://svnweb.freebsd.org/changeset/ports/444655

Log:
  * Updated to 1.7.1

  Changelog:	https://github.com/google/flatbuffers/releases/tag/v1.7.0

  PR:		220320
  Submitted by:	Yuri Victorovich <yuri@rawbw.com> (maintainer)
  Reviewed by:	lifanov (mentor)
  Approved by:	lifanov (mentor)
  Differential Revision:	https://reviews.freebsd.org/D11386

Changes:
  head/devel/flatbuffers/Makefile
  head/devel/flatbuffers/distinfo
Comment 4 Richard Gallamore freebsd_committer freebsd_triage 2017-06-29 19:08:21 UTC 
Committed, thanks!