Bug 220569 - security/hardening-check: Change MASTER_SITES to DEBIAN pool and remove SHEBANG_LANG
Summary: security/hardening-check: Change MASTER_SITES to DEBIAN pool and remove SHEBA...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Richard Gallamore
URL:
Keywords: easy, patch-ready
Depends on:
Blocks:
 
Reported: 2017-07-08 19:00 UTC by Richard Gallamore
Modified: 2017-07-09 03:03 UTC (History)
1 user (show)

See Also:
amutu: maintainer-feedback+
amutu: maintainer-feedback+

Attachments
hardening-check.diff (644 bytes, patch)
2017-07-08 19:00 UTC, Richard Gallamore 		amutu: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Richard Gallamore freebsd_committer freebsd_triage 2017-07-08 19:00:09 UTC 
Created attachment 184191 [details]
hardening-check.diff

* Changed MASTER_SITES to the DEBIAN pool
* Removed SHEBANG_LANG, this is only required for languages not already listed in Mk/Uses/shebandfix.mk
Comment 1 Jov 2017-07-08 23:33:04 UTC 
Thanks! I should read the doc more careful!
Comment 2 Richard Gallamore freebsd_committer freebsd_triage 2017-07-08 23:45:35 UTC 
(In reply to Jov from comment #1)
Its no problem, can you please approve the patch though. The flags on the PR is just for feedback. Attachment feedback is approved or disapproved by going to details, in the flag section ? --> + or - and submit. Previously the issue was that I would not request the feedback so it could not be given.
Comment 3 commit-hook freebsd_committer freebsd_triage 2017-07-09 02:48:43 UTC 
A commit references this bug:

Author: ultima
Date: Sun Jul  9 02:48:21 UTC 2017
New revision: 445362
URL: https://svnweb.freebsd.org/changeset/ports/445362

Log:
  * Changed MASTER_SITES to DEBIAN pool
  * Removed SHEBANG_LANG, shebangfix already includes this for perl

  PR:		220569
  Reported by:	matt
  Reviewed by:	lifanov (mentor), Jov <amutu@amutu.com> (maintainer)
  Approved by:	lifanov (mentor), Jov <amutu@amutu.com> (maintainer)
  Differential Revision:	https://reviews.freebsd.org/D11538

Changes:
  head/security/hardening-check/Makefile
Comment 4 Richard Gallamore freebsd_committer freebsd_triage 2017-07-09 03:03:54 UTC 
Committed, thanks!

(In reply to Jov from comment #1)
There are many pieces to ports and it is learned overtime. These items can easily missed by anyone. Only 2 items on a new port is great! Keep it up and you'll be a master in no time.