Bug 220791 - [PATCH] Update CONFLICTS_INSTALL in MySQL server ports and derivatives
Summary: [PATCH] Update CONFLICTS_INSTALL in MySQL server ports and derivatives
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Vasil Dimov
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2017-07-17 08:58 UTC by Vasil Dimov
Modified: 2017-08-15 23:40 UTC (History)
5 users (show)

See Also:
brnrd: maintainer-feedback+
vd: maintainer-feedback? (ale)
vd: maintainer-feedback? (feld)
flo: maintainer-feedback+
mmokhi: maintainer-feedback+
koobs: merge-quarterly?


Attachments
Extend CONFLICTS_INSTALL in conflicting ports. (4.24 KB, patch)
2017-07-17 08:58 UTC, Vasil Dimov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vasil Dimov freebsd_committer freebsd_triage 2017-07-17 08:58:31 UTC
Created attachment 184423 [details]
Extend CONFLICTS_INSTALL in conflicting ports.

databases/mysqlwsrep56-server has been present for some time and databases/mysqlwsrep57-server has been added just recently. Both ports conflict with other MySQL server ports and this has been reflected in databases/mysqlwsrep5[67]-server/Makefile but must also be reflected in all conflicting ports' Makefiles as well.

The conflicting ports are:
databases/mariadb100-server
databases/mariadb101-server
databases/mariadb102-server
databases/mariadb55-server
databases/mysql55-server
databases/mysql56-server
databases/mysql57-server
databases/mysql80-server
databases/percona55-server
databases/percona56-server
databases/percona57-server

There is not going to be mysqlwsrep*-client* ports (because the vanilla mysql*-client* ports suffice), so the entry in CONFLICTS just reads mysqlwsrep*.
Comment 1 Mahdi Mokhtari freebsd_committer freebsd_triage 2017-07-17 11:51:15 UTC
To me it seems fine.
Thanks for suggestion ;)
Comment 2 Bernard Spil freebsd_committer freebsd_triage 2017-07-24 09:59:18 UTC
That would do just fine.

Perhaps align with the other conflicts?
Comment 3 Vasil Dimov freebsd_committer freebsd_triage 2017-07-24 10:43:27 UTC
(In reply to Bernard Spil from comment #2)
Bernard,

"Perhaps align with the other conflicts?" -- what do you mean by that?
Comment 4 commit-hook freebsd_committer freebsd_triage 2017-08-14 05:37:54 UTC
A commit references this bug:

Author: vd
Date: Mon Aug 14 05:37:22 UTC 2017
New revision: 447926
URL: https://svnweb.freebsd.org/changeset/ports/447926

Log:
  MySQL ports: Extend CONFLICTS_INSTALL in conflicting ports.

  databases/mysqlwsrep56-server has been present for some time and
  databases/mysqlwsrep57-server has been added recently. Both ports
  conflict with other MySQL server ports and this has been reflected
  in databases/mysqlwsrep5[67]-server/Makefile but must also be
  reflected in all conflicting ports' Makefiles as well.

  The conflicting ports are:
  databases/mariadb100-server
  databases/mariadb101-server
  databases/mariadb102-server
  databases/mariadb55-server
  databases/mysql55-server
  databases/mysql56-server
  databases/mysql57-server
  databases/mysql80-server
  databases/percona55-server
  databases/percona56-server
  databases/percona57-server

  There is not going to be mysqlwsrep*-client* ports (because the vanilla
  mysql*-client* ports suffice), so the entry in CONFLICTS just reads
  mysqlwsrep*.

  PR:		220791
  Submitted by:	vd
  Approved by:	brnrd, ale (maintainer timeout), feld (maintainer timeout), flo, mmokhi, koobs

Changes:
  head/databases/mariadb100-server/Makefile
  head/databases/mariadb101-server/Makefile
  head/databases/mariadb102-server/Makefile
  head/databases/mariadb55-server/Makefile
  head/databases/mysql55-server/Makefile
  head/databases/mysql56-server/Makefile
  head/databases/mysql57-server/Makefile
  head/databases/mysql80-server/Makefile
  head/databases/percona55-server/Makefile
  head/databases/percona56-server/Makefile
  head/databases/percona57-server/Makefile
Comment 5 Mahdi Mokhtari freebsd_committer freebsd_triage 2017-08-15 23:40:05 UTC
(In reply to commit-hook from comment #4)
@vd, I'd say MFH would be good idea too, what do you think?