Bug 220815 - devel/zookeeper: Allows passing JVM options to RC
Summary: devel/zookeeper: Allows passing JVM options to RC
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Steven Kreuzer
URL:
Keywords: easy, feature, needs-qa
Depends on:
Blocks:
 
Reported: 2017-07-18 04:47 UTC by Pavel Timofeev
Modified: 2017-08-31 16:07 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (skreuzer)


Attachments
port patch (2.62 KB, patch)
2017-07-18 04:47 UTC, Pavel Timofeev
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Timofeev 2017-07-18 04:47:56 UTC
Created attachment 184461 [details]
port patch

- Add LICENSE
- Define config files as @sample
- Add ability to pass JVM options to rc script
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2017-07-18 13:08:05 UTC
Minor changes (related to ports infrastructure/compliance) can be relegated to the commit log message body rather than summary, unless they are the only changes

Thanks Tim!
Comment 2 Pavel Timofeev 2017-07-18 17:22:01 UTC
skreuzer@, also I wanted to say I think it's better to use bundled log4j and other jar lib stuff in this port
Comment 3 commit-hook freebsd_committer freebsd_triage 2017-08-31 16:07:18 UTC
A commit references this bug:

Author: skreuzer
Date: Thu Aug 31 16:06:36 UTC 2017
New revision: 449045
URL: https://svnweb.freebsd.org/changeset/ports/449045

Log:
  Add ability to pass JVM options to rc script
  Add LICENSE
  Define config files as @sample

  PR:		220815
  Submitted by:	timp87@gmail.com

Changes:
  head/devel/zookeeper/Makefile
  head/devel/zookeeper/files/zookeeper.in
  head/devel/zookeeper/pkg-plist
Comment 4 Steven Kreuzer freebsd_committer freebsd_triage 2017-08-31 16:07:54 UTC
Committed. Thanks!