Bug 220841 - sys/kern/ptrace_test:ptrace__PT_KILL_competing_stop fails periodically
Summary: sys/kern/ptrace_test:ptrace__PT_KILL_competing_stop fails periodically
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: tests (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Some People
Assignee: Alex Richardson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-19 00:46 UTC by Enji Cooper
Modified: 2024-11-25 04:02 UTC (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Enji Cooper freebsd_committer freebsd_triage 2017-07-19 00:46:35 UTC
I've seen this issue at least once before. Here's an example of it failing -- from
https://ci.freebsd.org/job/FreeBSD-head-amd64-test/3519/testReport/junit/sys.kern/ptrace_test/ptrace__PT_KILL_competing_stop/ :

/usr/src/tests/sys/kern/ptrace_test.c:2064: pl.pl_lwpid == main_lwp not met

This corresponds to this line:

315484     badger       ATF_REQUIRE(pl.pl_lwpid == main_lwp);
Comment 1 Enji Cooper freebsd_committer freebsd_triage 2017-10-23 07:27:26 UTC
Haven't seen this in a few months.. closing.
Comment 2 Li-Wen Hsu freebsd_committer freebsd_triage 2019-07-23 07:26:32 UTC
Still happens: https://ci.freebsd.org/job/FreeBSD-head-amd64-test/11941/testReport/junit/sys.kern/ptrace_test/ptrace__PT_KILL_competing_stop/

/usr/src/tests/sys/kern/ptrace_test.c:2187: pl.pl_flags & PL_FLAG_SCX not met
Comment 3 commit-hook freebsd_committer freebsd_triage 2019-07-23 07:57:26 UTC
A commit references this bug:

Author: lwhsu
Date: Tue Jul 23 07:56:43 UTC 2019
New revision: 350235
URL: https://svnweb.freebsd.org/changeset/base/350235

Log:
  Temporarily skip flakey test case
  sys.kern.ptrace_test.ptrace__PT_KILL_competing_stop

  PR:		220841
  Sponsored by:	The FreeBSD Foundation

Changes:
  head/tests/sys/kern/ptrace_test.c
Comment 4 commit-hook freebsd_committer freebsd_triage 2019-10-25 21:52:12 UTC
A commit references this bug:

Author: lwhsu
Date: Fri Oct 25 21:52:02 UTC 2019
New revision: 354105
URL: https://svnweb.freebsd.org/changeset/base/354105

Log:
  MFC r350211, r350220, r350235, r350238-r350239, r350295, r350512, r350700, r352219

  r350211:
  Temporarily skip flakey test case
  sys.kern.ptrace_test.ptrace__follow_fork_child_detached_unrelated_debugger

  PR:		239292
  Sponsored by:	The FreeBSD Foundation

  r350220:
  Fix URL.

  Sponsored by:	The FreeBSD Foundation

  r350235:
  Temporarily skip flakey test case
  sys.kern.ptrace_test.ptrace__PT_KILL_competing_stop

  PR:		220841
  Sponsored by:	The FreeBSD Foundation

  r350238:
  Temporarily skip flakey test case
  sys.kern.ptrace_test.ptrace__follow_fork_both_attached_unrelated_debugger

  PR:		239397
  Sponsored by:	The FreeBSD Foundation

  r350239:
  Temporarily skip flakey test case
  sys.kern.ptrace_test.ptrace__parent_sees_exit_after_child_debugger

  PR:		239399
  Sponsored by:	The FreeBSD Foundation

  r350295:
  Temporarily skip flakey test case
  sys.kern.ptrace_test.ptrace__follow_fork_parent_detached_unrelated_debugger

  PR:		239425
  Sponsored by:	The FreeBSD Foundation

  r350512:
  Only skip test cases sometimes failing in CI when they are running in CI

  Suggested by:	jhb
  Sponsored by:	The FreeBSD Foundation

  r350700:
  Get configuration variable with default value for not breaking default setting

  Reported by:	markj
  Sponsored by:	The FreeBSD Foundation

  r352219:
  Temporarily skip flakey test case sys.kern.ptrace_test.ptrace__getppid

  PR:		240510
  Sponsored by:	The FreeBSD Foundation

Changes:
_U  stable/12/
  stable/12/tests/sys/kern/ptrace_test.c
Comment 5 commit-hook freebsd_committer freebsd_triage 2019-10-28 13:07:03 UTC
A commit references this bug:

Author: lwhsu
Date: Mon Oct 28 13:06:02 UTC 2019
New revision: 354134
URL: https://svnweb.freebsd.org/changeset/base/354134

Log:
  MFC r350211, r350220, r350235, r350238-r350239, r350295, r350512, r350700, r352219

  r350211:
  Temporarily skip flakey test case
  sys.kern.ptrace_test.ptrace__follow_fork_child_detached_unrelated_debugger

  PR:		239292
  Sponsored by:	The FreeBSD Foundation

  r350220:
  Fix URL.

  Sponsored by:	The FreeBSD Foundation

  r350235:
  Temporarily skip flakey test case
  sys.kern.ptrace_test.ptrace__PT_KILL_competing_stop

  PR:		220841
  Sponsored by:	The FreeBSD Foundation

  r350238:
  Temporarily skip flakey test case
  sys.kern.ptrace_test.ptrace__follow_fork_both_attached_unrelated_debugger

  PR:		239397
  Sponsored by:	The FreeBSD Foundation

  r350239:
  Temporarily skip flakey test case
  sys.kern.ptrace_test.ptrace__parent_sees_exit_after_child_debugger

  PR:		239399
  Sponsored by:	The FreeBSD Foundation

  r350295:
  Temporarily skip flakey test case
  sys.kern.ptrace_test.ptrace__follow_fork_parent_detached_unrelated_debugger

  PR:		239425
  Sponsored by:	The FreeBSD Foundation

  r350512:
  Only skip test cases sometimes failing in CI when they are running in CI

  Suggested by:	jhb
  Sponsored by:	The FreeBSD Foundation

  r350700:
  Get configuration variable with default value for not breaking default setting

  Reported by:	markj
  Sponsored by:	The FreeBSD Foundation

  r352219:
  Temporarily skip flakey test case sys.kern.ptrace_test.ptrace__getppid

  PR:		240510
  Sponsored by:	The FreeBSD Foundation

Changes:
_U  stable/11/
  stable/11/tests/sys/kern/ptrace_test.c
Comment 6 commit-hook freebsd_committer freebsd_triage 2021-03-01 19:57:20 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=1032131464f1196ad674b30c14a9e611789a1061

commit 1032131464f1196ad674b30c14a9e611789a1061
Author:     Alex Richardson <arichardson@FreeBSD.org>
AuthorDate: 2021-03-01 18:51:02 +0000
Commit:     Alex Richardson <arichardson@FreeBSD.org>
CommitDate: 2021-03-01 19:56:05 +0000

    Remove atf_tc_skip calls from ptrace_test

    I've run these tests many times in a loop on multiple architectures and
    it works reliably for me, maybe it's time to retire these skips?
    This also adds an additional waitpid to one of the tests to avoid
    a potential race condition (suggested by markj@).

    PR:             239397, 244056, 239425, 240510, 220841, 243605
    Reviewed By:    markj
    Differential Revision: https://reviews.freebsd.org/D28888

 tests/sys/kern/ptrace_test.c | 29 ++---------------------------
 1 file changed, 2 insertions(+), 27 deletions(-)
Comment 7 commit-hook freebsd_committer freebsd_triage 2021-03-17 14:06:36 UTC
A commit in branch stable/13 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=80c34bad19795b6f4ddf9d6e339cf600118f05b0

commit 80c34bad19795b6f4ddf9d6e339cf600118f05b0
Author:     Alex Richardson <arichardson@FreeBSD.org>
AuthorDate: 2021-03-01 18:51:02 +0000
Commit:     Alex Richardson <arichardson@FreeBSD.org>
CommitDate: 2021-03-17 12:24:02 +0000

    Remove atf_tc_skip calls from ptrace_test

    I've run these tests many times in a loop on multiple architectures and
    it works reliably for me, maybe it's time to retire these skips?
    This also adds an additional waitpid to one of the tests to avoid
    a potential race condition (suggested by markj@).

    PR:             239397, 244056, 239425, 240510, 220841, 243605
    Reviewed By:    markj
    Differential Revision: https://reviews.freebsd.org/D28888

    (cherry picked from commit 1032131464f1196ad674b30c14a9e611789a1061)

 tests/sys/kern/ptrace_test.c | 29 ++---------------------------
 1 file changed, 2 insertions(+), 27 deletions(-)
Comment 8 Mark Linimon freebsd_committer freebsd_triage 2024-11-25 04:02:31 UTC
^Triage: committed and MFCed back in 2021.