Bug 220929 - net/wireshark-qt5: poudriere build fails as of r446353 (2.4.0) without DECRYPT
Summary: net/wireshark-qt5: poudriere build fails as of r446353 (2.4.0) without DECRYPT
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Joe Marcus Clarke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-22 23:27 UTC by John W. O'Brien
Modified: 2017-07-23 14:37 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (marcus)

Attachments
net/wireshark-qt5: Poudriere build log (54.33 KB, text/plain)
2017-07-22 23:27 UTC, John W. O'Brien 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John W. O'Brien 2017-07-22 23:27:01 UTC 
Created attachment 184606 [details]
net/wireshark-qt5: Poudriere build log

Observed behavior
=================

net/wireshark-qt5 build fails (under poudriere) at the configure check for the presence of libgcrypt (>=1.4.2). See attached build log. Configure log and list of installed packages will be produced upon request.


Expected behavior
=================

Port builds cleanly with any combination of OPTIONS (including !DECRYPT).


Analysis
========

Upstream seems to now require libgcrypt unconditionally [0].


Fix
===

Hypothetically, patch to remove DECRYPT option and unconditionally depend upon security/libgcrypt via LIB_DEPENDS. Patch and test artifacts to be produced upon request.


[0] https://github.com/wireshark/wireshark/commit/6b84ddee83e70aff944da084129624226b7a32fa
Comment 1 commit-hook freebsd_committer freebsd_triage 2017-07-23 14:34:40 UTC 
A commit references this bug:

Author: marcus
Date: Sun Jul 23 14:34:13 UTC 2017
New revision: 446483
URL: https://svnweb.freebsd.org/changeset/ports/446483

Log:
  Wireshark now depends on libgcrypt even in the non-DECRYPT
  case.  Not bumping PORTREVISION since the default was to
  have libgcrypt anyway.

  PR:		220929

Changes:
  head/net/wireshark/Makefile
Comment 2 Joe Marcus Clarke freebsd_committer freebsd_triage 2017-07-23 14:37:34 UTC 
Fixed.  Thanks for reporting.