Bug 221003 - sysutils/flexbackup: patch patch-flexbackup extended for three little issues
Summary: sysutils/flexbackup: patch patch-flexbackup extended for three little issues
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Tobias Kortkamp
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2017-07-25 14:46 UTC by Lars Herschke
Modified: 2019-01-29 09:34 UTC (History)
2 users (show)

See Also:
koobs: merge-quarterly?


Attachments
extended patch (14.64 KB, patch)
2017-07-25 14:46 UTC, Lars Herschke
koobs: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Herschke 2017-07-25 14:46:47 UTC
Created attachment 184702 [details]
extended patch

I have the present patchfile patch-flexbackup extended to fix three little issues.

1. flexbackup shows a perl deprecated warning with perl 5.16
2. lzma support compression level 0
3. compress flags doesn't work, if you use afio+lzma
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2017-07-26 03:08:57 UTC
Comment on attachment 184702 [details]
extended patch

Port has no maintainer, implicit approval (pending QA)
Comment 2 Steve Wills freebsd_committer freebsd_triage 2017-08-18 12:34:12 UTC
Patch doesn't apply cleanly for me.
Comment 3 Lars Herschke 2017-12-19 17:24:14 UTC
I have no problem with the patch, when i replace the file patch-flexbackup in the files-directory with the file from this bugreport and then build the port.

If i patch the file manually with the patch-command i also have no issues.

Here is the output:

Hmm...  Looks like a unified diff to me...
The text leading up to this was:
--------------------------
|--- flexbackup.orig    2003-10-10 14:12:09 UTC
|+++ flexbackup
--------------------------
Patching file flexbackup using Plan A...
Hunk #1 succeeded at 133.
Hunk #2 succeeded at 272.
Hunk #3 succeeded at 445.
Hunk #4 succeeded at 691.
Hunk #5 succeeded at 707.
Hunk #6 succeeded at 819.
Hunk #7 succeeded at 840.
Hunk #8 succeeded at 1053.
Hunk #9 succeeded at 1158.
Hunk #10 succeeded at 1304.
Hunk #11 succeeded at 1354.
Hunk #12 succeeded at 1370.
Hunk #13 succeeded at 1660.
Hunk #14 succeeded at 1686.
Hunk #15 succeeded at 1806.
Hunk #16 succeeded at 2688.
Hunk #17 succeeded at 2718.
Hunk #18 succeeded at 2768.
Hunk #19 succeeded at 3021.
Hunk #20 succeeded at 3089.
Hunk #21 succeeded at 3104.
Hunk #22 succeeded at 3258.
Hunk #23 succeeded at 3280.
Hunk #24 succeeded at 3447.
Hunk #25 succeeded at 3474.
Hunk #26 succeeded at 3822.
Hunk #27 succeeded at 3830.
Hunk #28 succeeded at 4884.
Hunk #29 succeeded at 5279.
Hunk #30 succeeded at 5287.
Hunk #31 succeeded at 5305.
Hunk #32 succeeded at 5349.
Hunk #33 succeeded at 5459.
Hunk #34 succeeded at 5749.
done
Comment 4 Tobias Kortkamp freebsd_committer freebsd_triage 2019-01-29 09:31:49 UTC
(In reply to Lars Herschke from comment #3)
It helps when port patches are generated from the port directory rather
than something that we should copy into files/ ourselves which we cannot
really automate. This is also outlined in the Porter's Handbook [1].

Anyway, committed. Thanks!

[1] https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/port-upgrading.html#svn-diff
Comment 5 commit-hook freebsd_committer freebsd_triage 2019-01-29 09:32:03 UTC
A commit references this bug:

Author: tobik
Date: Tue Jan 29 09:31:38 UTC 2019
New revision: 491550
URL: https://svnweb.freebsd.org/changeset/ports/491550

Log:
  sysutils/flexbackup: Fix some issues

  - flexbackup shows a perl deprecated warning with perl 5.16
  - lzma support compression level 0
  - compress flags do not work, if you use afio+lzma

  PR:		221003
  Submitted by:	Lars Herschke <lhersch@dssgmbh.de>

Changes:
  head/sysutils/flexbackup/Makefile
  head/sysutils/flexbackup/files/patch-flexbackup
Comment 6 commit-hook freebsd_committer freebsd_triage 2019-01-29 09:34:07 UTC
A commit references this bug:

Author: tobik
Date: Tue Jan 29 09:34:02 UTC 2019
New revision: 491551
URL: https://svnweb.freebsd.org/changeset/ports/491551

Log:
  MFH: r491550

  sysutils/flexbackup: Fix some issues

  - flexbackup shows a perl deprecated warning with perl 5.16
  - lzma support compression level 0
  - compress flags do not work, if you use afio+lzma

  PR:		221003
  Submitted by:	Lars Herschke <lhersch@dssgmbh.de>

  Approved by:	ports-secteam bug fix blanket

Changes:
_U  branches/2019Q1/
  branches/2019Q1/sysutils/flexbackup/Makefile
  branches/2019Q1/sysutils/flexbackup/files/patch-flexbackup