Bug 221049 - struct ata_params word 49 has bits for IORDY and IORDYDIS swapped
Summary: struct ata_params word 49 has bits for IORDY and IORDYDIS swapped
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Some People
Assignee: Alexander Motin
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2017-07-27 16:07 UTC by aaron.styx
Modified: 2017-08-05 08:37 UTC (History)
2 users (show)

See Also:

Attachments
Fix IORDY bits (537 bytes, patch)
2017-07-27 16:07 UTC, aaron.styx 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description aaron.styx 2017-07-27 16:07:27 UTC 
Created attachment 184771 [details]
Fix IORDY bits

In sys/sys/ata.h, word 49 of the struct ata_params defines ATA_SUPPORT_IORDYDIS and ATA_SUPPORT_IORDY. According to the ATA spec, IORDYDIS should be bit 10, IORDY should be bit 11. Attached a fix.
Comment 1 commit-hook freebsd_committer freebsd_triage 2017-07-29 13:54:42 UTC 
A commit references this bug:

Author: mav
Date: Sat Jul 29 13:54:28 UTC 2017
New revision: 321685
URL: https://svnweb.freebsd.org/changeset/base/321685

Log:
  Fix IORDY bits definition.

  According to the ATA specs, IORDYDIS should be bit 10, IORDY -- bit 11.

  PR:		221049
  Submitted by:	aaron.styx@baesystems.com
  MFC after:	1 week

Changes:
  head/sys/sys/ata.h
Comment 2 Alexander Motin freebsd_committer freebsd_triage 2017-07-29 13:55:06 UTC 
Fixed.  Thank you!
Comment 3 commit-hook freebsd_committer freebsd_triage 2017-08-05 08:37:48 UTC 
A commit references this bug:

Author: mav
Date: Sat Aug  5 08:37:09 UTC 2017
New revision: 322080
URL: https://svnweb.freebsd.org/changeset/base/322080

Log:
  MFC r321685: Fix IORDY bits definition.

  According to the ATA specs, IORDYDIS should be bit 10, IORDY -- bit 11.

  PR:		221049
  Submitted by:	aaron.styx@baesystems.com

Changes:
_U  stable/11/
  stable/11/sys/sys/ata.h
Comment 4 commit-hook freebsd_committer freebsd_triage 2017-08-05 08:37:50 UTC 
A commit references this bug:

Author: mav
Date: Sat Aug  5 08:37:38 UTC 2017
New revision: 322081
URL: https://svnweb.freebsd.org/changeset/base/322081

Log:
  MFC r321685: Fix IORDY bits definition.

  According to the ATA specs, IORDYDIS should be bit 10, IORDY -- bit 11.

  PR:             221049
  Submitted by:   aaron.styx@baesystems.com

Changes:
_U  stable/10/
  stable/10/sys/sys/ata.h