Created attachment 184849 [details] The diff Revision history for Dancer2-Plugin-Auth-Extensible 0.704 Wed 12 Apr 15:04:46 CEST 2017 [BUG FIXES] * Fix password reset when user is object (Andy Beverley GH#73) * Fix custom login template (Tadeusz “tadzik” Sośnierz GH#72) [MISC] * Deduplicate code related to login page rendering (Tadeusz “tadzik” Sośnierz GH#71) 0.703 Tue 29 Nov 10:25:10 CET 2016 [BUG FIXES] * Bump dep on Dancer2 to 0.204000. Prior to that release after `forward` `params` were still available but were not cloned into `parameters`. This should fix GH #66. 0.702 Mon 28 Nov 12:34:53 CET 2016 [TESTS] * Chasing down GH#66 and (hopefully) cut down on unexpected warnings causing no-realms-configured test to fail. 0.701 Tue 22 Nov 10:32:27 CET 2016 [BUG FIXES] * Try to make File::ShareDir::Install more reliable (Peter Mottram). [TESTS] * Stop tests failing due to 'Name "YAML::XS::NonStrict" used only once' warning (Peter Mottram). * Remove debug log from output in no-reset-password-handle test (Peter Mottram). 0.700 Fri 18 Nov 13:13:36 CET 2016 [ENHANCEMENTS] * Add new "no-redirect" login handler (Peter Mottram). * Break out /login and /login/denied html into external files (Peter Mottram). [BUG FIXES] * Escape all params used as input to default login page to prevent potential injection attacks (Peter Mottram). * Bump dep on Test::Deep for noneof (Peter Mottram GH#65). [TESTS] * Lots more tests added resulting in much better coverage (Peter Mottram). * Huge number of new tests added (Peter Mottram). * Add build dep on HTTP::Cookies (Peter Mottram). [MISC] * Remove old Provider::Example since Provider::Config is a much better example provider (Peter Mottram). * logged_in_user_lastlogin now stored in session as epoch (Peter Mottram). * Removed unused _try_realms method (Peter Mottram).
Hi Henk. Thanks for your work. Please, confirm that this change passes QA (portlint, poudriere in particular). For more information, see: https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/testing.html It's good to test all ports that depends on this one: security/p5-Dancer2-Plugin-Auth-Extensible-Provider-DBIC security/p5-Dancer2-Plugin-Auth-Extensible-Provider-Database security/p5-Dancer2-Plugin-Auth-Extensible-Provider-IMAP security/p5-Dancer2-Plugin-Auth-Extensible-Provider-Usergroup www/p5-Dancer2-Plugin-Interchange6 Regards.
Tests: - make test - port test - portlint - portmaster p5- And some more.
Hi Henk, thanks for submitting this update. I just want to clarify something with you: it looks to me like the new File::Share dependency is more a RUN and BUILD _DEPENDS than a TEST_DEPENDS only, since it is included in the Extensible.pm module. Could you please double check the dependency list and confirm if yes or not the File::Share module must be moved to BUILD_DEPENDS? Thanks, Frederic
Hi Frederic File::Share is part of perl core. No port depends on devel/p5-File-Share From pkg-descr: File::Share is a dropin replacement for File::ShareDir. It supports the dist_dir and dist_file functions, except these functions have been enhanced to understand when the developer's local ./share/ directory should be used. --- You don't need devel/p5-File-Share to build/install/run D2PAE Only "make test" needs the developer's local ./share/ directory. HTH Henk
(In reply to Henk van Oers from comment #4) Hi again Henk, sorry but I'm a bit confused by your answer. First I fail to see how File::Share is part of Perl core. I checked on http://perldoc.perl.org/index-modules-F.html but I did not find it, and 'corelist -a File::Share' returns the following: Data for 2017-07-20 File::Share was not in CORE (or so I think) Then I tried the simple following test: perl -MDancer::Plugin::Auth::Extensible -e 'print "OK\n"' but it failed with this error: Can't locate File/Share.pm in @INC (you may need to install the File::Share module) (@INC contains: /usr/local/lib/perl5/site_perl/mach/5.24 /usr/local/lib/perl5/site_perl /usr/local/lib/perl5/5.24/mach /usr/local/lib/perl5/5.24 .) at /usr/local/lib/perl5/site_perl/Dancer2/Plugin/Auth/Extensible.pm line 11. BEGIN failed--compilation aborted at /usr/local/lib/perl5/site_perl/Dancer2/Plugin/Auth/Extensible.pm line 11. So unless I'm missing something obvious here, it is my current understanding that Dancer::Plugin::Auth::Extensible uses File::Share explicitly (as seen on line 11 in the module's source at http://cpansearch.perl.org/src/HORNBURG/Dancer2-Plugin-Auth-Extensible-0.704/lib/Dancer2/Plugin/Auth/Extensible.pm), which is not in core. I would greatly appreciate your feedback on the above before I can update the port. Cheers, Frederic
I'm a bit confused too. When I delete devel/p5-File-Share , I can still install D2PAE. I think I have to many p5- ports installed. Shall I make a new diff?
(In reply to Henk van Oers from comment #6) Yes, install is fine on my side too, even when File::Share is not present. But can you actually use D2PAE module afterwards? That's what I tried to do with my simple one-liner, which failed: perl -MDancer::Plugin::Auth::Extensible -e 'print "OK\n"' For the diff, there's no need to provide another one, I can easily move the File::Share dependency from TEST_ to RUN_DEPENDENCY, if you agree with this change from after our discussion. Just let me know if you are ok with the change I suggest, or please tell me if you prefer to apply any other change to your port. Cheers, Frederic
I am ok with the change. BTW: Your one-liner misses a 2. :)
A commit references this bug: Author: culot Date: Tue Aug 8 13:44:20 UTC 2017 New revision: 447543 URL: https://svnweb.freebsd.org/changeset/ports/447543 Log: - Update to 0.704 Changes: http://search.cpan.org/dist/Dancer2-Plugin-Auth-Extensible/Changes PR: 221103 (based on) Submitted by: Henk van Oers <hvo.pm@xs4all.nl> (maintainer) Changes: head/security/p5-Dancer2-Plugin-Auth-Extensible/Makefile head/security/p5-Dancer2-Plugin-Auth-Extensible/distinfo head/security/p5-Dancer2-Plugin-Auth-Extensible/pkg-plist