Bug 221231 - [NEW PORT] audio/tap-plugins-lv2: LV2 port for the TAP (Tom's Audio Processing) plugins
Summary: [NEW PORT] audio/tap-plugins-lv2: LV2 port for the TAP (Tom's Audio Processin...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Richard Gallamore
URL:
Keywords: feature
Depends on:
Blocks:
 
Reported: 2017-08-04 21:38 UTC by Yuri Victorovich
Modified: 2017-08-21 07:08 UTC (History)
1 user (show)

See Also:

Attachments
shar (15.47 KB, text/plain)
2017-08-04 21:38 UTC, Yuri Victorovich 		no flags Details
shar (15.47 KB, text/plain)
2017-08-04 21:40 UTC, Yuri Victorovich 		no flags Details
shar (14.78 KB, text/plain)
2017-08-11 22:53 UTC, Yuri Victorovich 		no flags Details
shar archive (14.80 KB, text/plain)
2017-08-20 23:42 UTC, Yuri Victorovich 		no flags Details
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer freebsd_triage 2017-08-04 21:38:49 UTC 
Created attachment 185030 [details]
shar

QAs:
* pourdriere
* portlint
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2017-08-04 21:40:50 UTC 
Created attachment 185031 [details]
shar
Comment 2 Richard Gallamore freebsd_committer freebsd_triage 2017-08-11 19:31:21 UTC 
* Portversion for github tag should be like so g20160125
I know this isn't in the porters handbook yet but it will be.

* Instead of adding a patch for patch-Makefile, consider stripping with REINPLACE_CMD

* Only 1 WWW: in pkg-descr[1]

* There are many files in the ${PREFIX}/lib directory that aren't libs. Should these be in DATADIR?


[1] https://www.freebsd.org/doc/en/books/porters-handbook/book.html#porting-desc
Comment 3 Yuri Victorovich freebsd_committer freebsd_triage 2017-08-11 22:53:25 UTC 
Created attachment 185299 [details]
shar
Comment 4 Yuri Victorovich freebsd_committer freebsd_triage 2017-08-11 22:53:50 UTC 
FIxed all except for this one:

> * There are many files in the ${PREFIX}/lib directory that aren't libs. Should these be in DATADIR?

No, not for LV2 plugins.
Comment 5 Yuri Victorovich freebsd_committer freebsd_triage 2017-08-20 23:42:39 UTC 
Created attachment 185619 [details]
shar archive

Moved 'g' to PKGNAMEPREFIX, sorry.
Comment 6 commit-hook freebsd_committer freebsd_triage 2017-08-21 07:05:26 UTC 
A commit references this bug:

Author: ultima
Date: Mon Aug 21 07:04:36 UTC 2017
New revision: 448454
URL: https://svnweb.freebsd.org/changeset/ports/448454

Log:
  This is the LV2 porty of Tom's Audio Processing plugins.
  Tom's Audio Processing plugins is a selection of LADSPA plugins for audio
  engineering on the Linux platform. Intended for use in a professional DAW
  environment such as Ardour, it includes high quality reverberation, echo,
  eq, limiter & more.

  WWW: http://tap-plugins.sourceforge.net/

  PR:		221231
  Submitted by:	Yuri Victorovich (maintainer)
  Reviewed by:	matthew (mentor)
  Approved by:	matthew (mentor)
  Differential Revision:	https://reviews.freebsd.org/D12093

Changes:
  head/audio/Makefile
  head/audio/tap-plugins-lv2/
  head/audio/tap-plugins-lv2/Makefile
  head/audio/tap-plugins-lv2/distinfo
  head/audio/tap-plugins-lv2/pkg-descr
  head/audio/tap-plugins-lv2/pkg-plist
Comment 7 Richard Gallamore freebsd_committer freebsd_triage 2017-08-21 07:08:04 UTC 
Committed, thanks!