Bug 221398 - [NEW PORT] audio/rtmidi: Set of C++ classes that provide a common API for realtime MIDI I/O
Summary: [NEW PORT] audio/rtmidi: Set of C++ classes that provide a common API for rea...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Richard Gallamore
URL:
Keywords:
Depends on:
Blocks: 221400
  Show dependency treegraph
 
Reported: 2017-08-10 20:25 UTC by Yuri Victorovich
Modified: 2017-08-19 18:16 UTC (History)
1 user (show)

See Also:


Attachments
shar (4.41 KB, text/plain)
2017-08-10 20:25 UTC, Yuri Victorovich
no flags Details
shar (5.28 KB, text/plain)
2017-08-11 05:51 UTC, Yuri Victorovich
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer freebsd_triage 2017-08-10 20:25:39 UTC
Created attachment 185242 [details]
shar

QAs:
* pourdriere 11.1 amd64
* portlint
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2017-08-11 05:51:41 UTC
Created attachment 185263 [details]
shar
Comment 2 Richard Gallamore freebsd_committer freebsd_triage 2017-08-19 00:59:35 UTC
Looks good except for port version, please follow example 5.14[1] when using GH_TAGNAME. Also, it would be nice if upstream could adapt to building natively on freebsd without patches. Added fixes and is pending.

[1] https://www.freebsd.org/doc/en/books/porters-handbook/makefile-distfiles.html#makefile-master_sites-github-ex1
Comment 3 commit-hook freebsd_committer freebsd_triage 2017-08-19 17:53:47 UTC
A commit references this bug:

Author: ultima
Date: Sat Aug 19 17:53:00 UTC 2017
New revision: 448348
URL: https://svnweb.freebsd.org/changeset/ports/448348

Log:
  RtMidi is a set of C++ classes (RtMidiIn, RtMidiOut, and API specific classes)
  that provide a common API (Application Programming Interface) for realtime MIDI
  input/output across Linux (ALSA, JACK), Macintosh OS X (CoreMIDI, JACK), and
  Windows (Multimedia Library) operating systems. RtMidi significantly simplifies
  the process of interacting with computer MIDI hardware and software. It was
  designed with the following goals:
  * object oriented C++ design
  * simple, common API across all supported platforms
  * only one header and one source file for easy inclusion in programming projects
  * MIDI device enumeration

  WWW: https://github.com/thestk/rtmidi

  PR:		221398
  Submitted by:	Yuri Victorovich (maintainer)
  Reviewed by:	matthew (mentor)
  Approved by:	matthew (mentor)
  Differential Revision:	https://reviews.freebsd.org/D12078

Changes:
  head/audio/Makefile
  head/audio/rtmidi/
  head/audio/rtmidi/Makefile
  head/audio/rtmidi/distinfo
  head/audio/rtmidi/files/
  head/audio/rtmidi/files/patch-configure.ac
  head/audio/rtmidi/pkg-descr
  head/audio/rtmidi/pkg-plist
Comment 4 Richard Gallamore freebsd_committer freebsd_triage 2017-08-19 18:16:39 UTC
Committed, thanks!