Created attachment 186163 [details] qpopper-4.1.0_6.patch Change MASTER_SITES Add LICENSE Delete unnecessary variables OPTIONS optimization portlint(1) Compliant
I am currently in the direct path of Irma and will probably not have power for a few weeks. In addition, I no longer use qpopper. However, The only potential issue I see with this patch is the re-introduction of APOP. In the past APOP caused numerous issues for users and was removed from the default configuration. I don't know how may are still using qpopper and if they are using APOP. -- Doug bc979@lafn.org
Would you like to remove the APOP function from the option?(In reply to bc979 from comment #1) Would you like to remove the APOP function from the option?
It doesn't matter to me. I brought that up because of the previous discussions a few years ago. I am good with it either way.
(In reply to takefu from comment #0) The patch doesn't apply anymore and needs a rebase. Since you have to update the patch anyway, could you please group all option descriptions into one block before the options helpers (see [1])? [1] https://www.freebsd.org/doc/en/books/porters-handbook/porting-order-options.html (In reply to bc979 from comment #1) > In addition, I no longer use qpopper. Should we reset MAINTAINER as well then?
A commit references this bug: Author: tobik Date: Tue Dec 25 07:16:02 UTC 2018 New revision: 488295 URL: https://svnweb.freebsd.org/changeset/ports/488295 Log: mail/qpopper: Reset maintainer The maintainer no longer uses qpopper. PR: 222135 Changes: head/mail/qpopper/Makefile
Closing as patch wasn't rebased and no additional feedback was given for > 4 months.