Bug 222585 - [maintainer-update] lang/opencoarrays update to 1.9.3
Summary: [maintainer-update] lang/opencoarrays update to 1.9.3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tijl Coosemans
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-09-25 07:34 UTC by Anton Shterenlikht
Modified: 2018-02-19 18:07 UTC (History)
2 users (show)

See Also:


Attachments
lang/opencoarrays svn diff - update from 1.9.1 to 1.9.2 (3.42 KB, patch)
2017-09-25 07:34 UTC, Anton Shterenlikht
swills: maintainer-approval+
Details | Diff
lang/opencoarrays update to 1.9.3 (3.12 KB, patch)
2018-01-11 13:24 UTC, Anton Shterenlikht
no flags Details | Diff
lang/opencoarrays update to 1.9.3 (3.16 KB, patch)
2018-01-12 16:24 UTC, Anton Shterenlikht
no flags Details | Diff
Latest patch checked by tijl@ (3.39 KB, patch)
2018-02-19 15:39 UTC, Anton Shterenlikht
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anton Shterenlikht 2017-09-25 07:34:43 UTC
Created attachment 186694 [details]
lang/opencoarrays svn diff - update from 1.9.1 to 1.9.2

Please check pkg-plist. I'm not sure if this change is right:

-include/OpenCoarrays/GNU/%%GCC_VER%%/opencoarrays.mod
+include/OpenCoarrays-1.9.2_GNU-6.4.0/opencoarrays.mod
Comment 1 Thomas Zander freebsd_committer freebsd_triage 2017-10-03 12:19:47 UTC
(In reply to Anton Shterenlikht from comment #0)

The "6.4.0" is most likely obtained from the GCC version string. Could you look into this? It's not good if the plist of a port changes because the compiler version string changes somewhere else in the ports tree.
Comment 2 Anton Shterenlikht 2017-10-26 09:54:34 UTC
Sorry for the delay.
I need help.

As far as I can see the upstream does detailed checks for the Fortran
compiler version and gets 6.4.0. It then uses this string
in a path name:

-- Installing: /usr/ports/lang/opencoarrays/work/stage/usr/local/include/OpenCoarrays-1.9.2_GNU-6.4.0
-- Installing: /usr/ports/lang/opencoarrays/work/stage/usr/local/include/OpenCoarrays-1.9.2_GNU-6.4.0/opencoarrays.mod

However, all I have it GCC_VER which gives me just "6", so using

include/OpenCoarrays-1.9.2_GNU-%%GCC_VER%%/opencoarrays.mod

in pkg-plist gives this error:

===>   Registering installation for opencoarrays-1.9.2_1
pkg-static: Unable to access file /usr/ports/lang/opencoarrays/work/stage/usr/local/include/OpenCoarrays-1.9.2_GNU-6/opencoarrays.mod:No such file or directory

So, the question - is there an easy way to set a var
in the Makefile to the full Fortran compiler version, e.g. 6.4.0?
If not, the only way I see is to overwrite the upstream's
file name with GCC_VER. I can probably do this e.g. with ${REINPLACE_CMD}.

Please advise

Thanks

Anton
Comment 3 Thomas Zander freebsd_committer freebsd_triage 2017-11-11 11:52:52 UTC
(In reply to Anton Shterenlikht from comment #2)

Probably the most clean solution is to locate where the compiler string is set in the build system and than patch is to simply not do that. (and proposing this as an upstream change)
Comment 4 Anton Shterenlikht 2018-01-11 13:24:40 UTC
Created attachment 189611 [details]
lang/opencoarrays update to 1.9.3

seems to build and package fine.
All tests pass.
Comment 5 Anton Shterenlikht 2018-01-12 16:24:48 UTC
Created attachment 189655 [details]
lang/opencoarrays update to 1.9.3

previous patch was contaminated by unclean environment.
The new patch was checked with synth.
Comment 6 Anton Shterenlikht 2018-02-19 15:39:09 UTC
Created attachment 190806 [details]
Latest patch checked by tijl@

From tijl@: with FreeBSD 12 (r329260): All tests pass with both MPICH and OpenMPI.

With FreeBSD 11 I'm seeing some test failures.

Still, time to update the port.
Comment 7 commit-hook freebsd_committer freebsd_triage 2018-02-19 18:04:38 UTC
A commit references this bug:

Author: tijl
Date: Mon Feb 19 18:04:11 UTC 2018
New revision: 462341
URL: https://svnweb.freebsd.org/changeset/ports/462341

Log:
  Update to 1.9.3.

  PR:		222585
  Submitted by:	Anton Shterenlikht <as@cmplx.uk> (maintainer)

Changes:
  head/lang/opencoarrays/Makefile
  head/lang/opencoarrays/distinfo
  head/lang/opencoarrays/pkg-descr
  head/lang/opencoarrays/pkg-plist