Bug 222939 - refactor `make po'
Summary: refactor `make po'
Status: Closed FIXED
Alias: None
Product: Documentation
Classification: Unclassified
Component: Books & Articles (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Wolfram Schneider
URL:
Keywords:
Depends on: 222944
Blocks:
  Show dependency tree / graph
 
Reported: 2017-10-11 20:33 UTC by Wolfram Schneider
Modified: 2017-10-12 16:06 UTC (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wolfram Schneider freebsd_committer freebsd_triage 2017-10-11 20:33:51 UTC 
I looked at the code in doc/share/mk/doc.docbook.mk

I wish we refactor the code and move it out to a separate make
file, lets call it doc.translate.mk  (or doc.docbook-translate.mk)
Comment 1 Wolfram Schneider freebsd_committer freebsd_triage 2017-10-12 08:23:40 UTC 
If you run `make po' in an english sub-directory, it will print a warning and stop the build with exit 1.

This makes other things complicated, e.g. a recursive build.

IMHO we should print a warning, and ignore it (exit 0).
Comment 2 commit-hook freebsd_committer freebsd_triage 2017-10-12 14:14:49 UTC 
A commit references this bug:

Author: wosch
Date: Thu Oct 12 14:13:48 UTC 2017
New revision: 51106
URL: https://svnweb.freebsd.org/changeset/doc/51106

Log:
  refactor translation to a new make file "doc.translate.mk"

  PR: 222939

Changes:
  head/share/mk/doc.docbook.mk
  head/share/mk/doc.translate.mk
Comment 3 commit-hook freebsd_committer freebsd_triage 2017-10-12 14:39:12 UTC 
A commit references this bug:

Author: wosch
Date: Thu Oct 12 14:38:11 UTC 2017
New revision: 51109
URL: https://svnweb.freebsd.org/changeset/doc/51109

Log:
  no fatal errors for english documents

  refactor to use make syntax instead shell/test scripts

  PR: 222939

Changes:
  head/share/Makefile
  head/share/mk/doc.translate.mk
Comment 4 commit-hook freebsd_committer freebsd_triage 2017-10-12 14:58:30 UTC 
A commit references this bug:

Author: wosch
Date: Thu Oct 12 14:57:29 UTC 2017
New revision: 51110
URL: https://svnweb.freebsd.org/changeset/doc/51110

Log:
  refactor to use make syntax instead shell/test scripts

  PR: 222939

Changes:
  head/share/mk/doc.translate.mk
Comment 5 commit-hook freebsd_committer freebsd_triage 2017-10-12 14:58:32 UTC 
A commit references this bug:

Author: wosch
Date: Thu Oct 12 14:57:50 UTC 2017
New revision: 51111
URL: https://svnweb.freebsd.org/changeset/doc/51111

Log:
  refactor to use make syntax instead shell/test scripts

  PR: 222939

Changes:
  head/share/mk/doc.translate.mk
Comment 6 commit-hook freebsd_committer freebsd_triage 2017-10-12 15:06:40 UTC 
A commit references this bug:

Author: wosch
Date: Thu Oct 12 15:05:42 UTC 2017
New revision: 51112
URL: https://svnweb.freebsd.org/changeset/doc/51112

Log:
  standard verbose make output.

  If you do not like this, use `make -s po'

  PR: 222939

Changes:
  head/share/mk/doc.translate.mk