Bug 223119 - libc++experimental was disabled for arm but now builds fine.
Summary: libc++experimental was disabled for arm but now builds fine.
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: arm (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: Dimitry Andric
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-19 21:25 UTC by George Abdelmalik
Modified: 2017-10-24 06:49 UTC (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description George Abdelmalik 2017-10-19 21:25:55 UTC
Back in May libc++experimental was hooked into the build however disabled for arm and mips due to compilation failure.

I've just successfully built the library for svn revision 323729. This is post the import of Clang 5.0 which occurred in late July.

The only conclusion I can make from this is that the original issue has been fixed by that subsequent release.

It would be great to have it hooked up again for arm, I can't say anything for mips as I don't run that platform.

My local patch is below.

Thanks for your attention.
Regards, George.

Index: lib/Makefile
===================================================================
--- lib/Makefile	(revision 323729)
+++ lib/Makefile	(working copy)
@@ -158,7 +158,7 @@
 .if ${MK_LIBCPLUSPLUS} != "no"
 _libcxxrt=	libcxxrt
 _libcplusplus=	libc++
-.if ${MACHINE_CPUARCH} != "arm" && ${MACHINE_CPUARCH} != "mips"
+.if ${MACHINE_CPUARCH} != "mips"
 _libcplusplus+=	libc++experimental
 .endif
 .endif
Comment 1 Dimitry Andric freebsd_committer freebsd_triage 2017-10-21 10:58:54 UTC
Yes, I think this should now work fine with libc++ 5.0.0, as the failing parts were overhauled to be independent of whether time_t is 32 or 64 bit.

In fact, the mips check can probably also be removed.  I'm doing a universe build now with both checks removed, to make sure.
Comment 2 commit-hook freebsd_committer freebsd_triage 2017-10-21 18:22:29 UTC
A commit references this bug:

Author: dim
Date: Sat Oct 21 18:21:44 UTC 2017
New revision: 324825
URL: https://svnweb.freebsd.org/changeset/base/324825

Log:
  After the import of libc++ 5.0.0, there is no need to disable building
  libc++experimental.a on arm (r318654) and mips (r318859) anymore, since
  upstream fixed the static assertions which would occur.

  Noticed by:	George Abdelmalik <gabdelmalik@uniridge.com.au>
  PR:		223119
  MFC after:	3 days

Changes:
  head/lib/Makefile