Bug 223155 - The file(1) utility is confused about dump dates
Summary: The file(1) utility is confused about dump dates
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: 10.4-RELEASE
Hardware: Any Any
: --- Affects Some People
Assignee: Oleksandr Tymoshenko
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2017-10-22 05:24 UTC by Victor Sudakov
Modified: 2019-01-16 04:04 UTC (History)
3 users (show)

See Also:


Attachments
0001-Fix-order-of-previous-dump-and-this-dump-dates.patch (1.40 KB, patch)
2018-06-25 21:01 UTC, Oleksandr Tymoshenko
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Victor Sudakov 2017-10-22 05:24:10 UTC
The file(1) utility erroneously swaps the previous and the current dump dates, in fact in a chronologically impossible order: 



restore > what
Dump   date: Sat Oct 21 23:25:25 2017
Dumped from: Sun Oct 15 03:13:21 2017
Level 5 dump of / on techno2.sibptus.transneft.ru:/dev/da0p2
Label: none
restore > quit

$ file techno2.dmp 
techno2.dmp: new-fs dump file (ufs2, little endian),  Previous dump Sat Oct 21 16:25:25 2017, This dump Sat Oct 14 20:13:21 2017, Volume 1, Level 5, type: tape header, Label none, Filesystem /, Device /dev/da0p2, Host techno2.sibptus.transneft.ru,
$
Comment 1 Victor Sudakov 2018-06-24 05:59:14 UTC
Ping
Comment 2 Oleksandr Tymoshenko freebsd_committer freebsd_triage 2018-06-25 21:01:33 UTC
Created attachment 194635 [details]
0001-Fix-order-of-previous-dump-and-this-dump-dates.patch
Comment 4 commit-hook freebsd_committer freebsd_triage 2018-06-26 18:54:18 UTC
A commit references this bug:

Author: gonzo
Date: Tue Jun 26 18:53:52 UTC 2018
New revision: 335675
URL: https://svnweb.freebsd.org/changeset/base/335675

Log:
  Fix file(1) dumpdate reporting for dump(8) files

  Magic file for dump(8) had this dump and previous dump dates reversed.
  Fix order for all three flavours of the dump(8) format.
  This fix was committed to upstream repo as magic/Magdir/dump,v 1.17
  and will be merged during next vendor import.

  PR:		223155
  MFC after:	2 weeks

Changes:
  head/contrib/file/magic/Magdir/dump
Comment 5 commit-hook freebsd_committer freebsd_triage 2019-01-16 04:02:19 UTC
A commit references this bug:

Author: gonzo
Date: Wed Jan 16 04:01:31 UTC 2019
New revision: 343079
URL: https://svnweb.freebsd.org/changeset/base/343079

Log:
  MFC r335675:

  Fix file(1) dumpdate reporting for dump(8) files

  Magic file for dump(8) had this dump and previous dump dates reversed.
  Fix order for all three flavours of the dump(8) format.
  This fix was committed to upstream repo as magic/Magdir/dump,v 1.17
  and will be merged during next vendor import.

  PR:		223155

Changes:
  stable/11/contrib/file/magic/Magdir/dump