Bug 223283 - [maintainer-update] www/gitea update to 1.2.2
Summary: [maintainer-update] www/gitea update to 1.2.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-27 17:00 UTC by Stefan Bethke
Modified: 2017-10-29 07:56 UTC (History)
2 users (show)

See Also:

Attachments
Update to 1.2.2, log console to syslog (1.58 KB, text/plain)
2017-10-27 17:00 UTC, Stefan Bethke 		no flags Details
Update rc script, bringing the port to 1.2.2_1 (1017 bytes, text/plain)
2017-10-28 11:15 UTC, Stefan Bethke 		no flags Details
gitea.diff (1.44 KB, patch)
2017-10-28 14:31 UTC, Tobias Kortkamp 		stb: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Bethke 2017-10-27 17:00:41 UTC 
Created attachment 187528 [details]
Update to 1.2.2, log console to syslog

Update gitea to version 1.2.2

Bugfixes.

Release notes: https://blog.gitea.io/2017/10/release-of-1.2.2/

Also start gitea with its stdout and stderr logged to syslog (daemon/debug by default) to aid in configuration debugging.
Comment 1 commit-hook freebsd_committer freebsd_triage 2017-10-27 17:55:35 UTC 
A commit references this bug:

Author: tobik
Date: Fri Oct 27 17:55:25 UTC 2017
New revision: 453018
URL: https://svnweb.freebsd.org/changeset/ports/453018

Log:
  www/gitea: Update to 1.2.2

  Also start gitea with its stdout and stderr logged to syslog
  (daemon/debug by default) to aid in configuration debugging.

  Changes:	https://blog.gitea.io/2017/10/release-of-1.2.2/
  PR:		223283
  Submitted by:	stb@lassitu.de (maintainer)

Changes:
  head/www/gitea/Makefile
  head/www/gitea/distinfo
  head/www/gitea/files/gitea.in
Comment 2 Tobias Kortkamp freebsd_committer freebsd_triage 2017-10-27 17:55:48 UTC 
Committed. Thanks!
Comment 3 Tobias Kortkamp freebsd_committer freebsd_triage 2017-10-28 10:24:51 UTC 
I'm reopening this since it breaks gitea on FreeBSD 10.x where daemon(8) doesn't
have -l and -s.

https://www.freebsd.org/cgi/man.cgi?query=daemon&apropos=0&sektion=0&manpath=FreeBSD+10.4-RELEASE+and+Ports&arch=default&format=html
Comment 4 Stefan Bethke 2017-10-28 10:25:41 UTC 
Sorry about that, I'm on it.
Comment 5 Stefan Bethke 2017-10-28 11:15:45 UTC 
Created attachment 187535 [details]
Update rc script, bringing the port to 1.2.2_1

I believe this should fix the daemon invocation on systems prior to 11.1-RELEASE, where the new daemon(8) options for syslog where introduced (r317855).
Comment 6 Tobias Kortkamp freebsd_committer freebsd_triage 2017-10-28 14:31:42 UTC 
Created attachment 187537 [details]
gitea.diff
Comment 7 Tobias Kortkamp freebsd_committer freebsd_triage 2017-10-28 14:32:00 UTC 
(In reply to stb from comment #5)

> I believe this should fix the daemon invocation on systems prior to 11.1-RELEASE, where the new daemon(8) options for syslog where introduced (r317855).

Yes, that's probably the most straightforward solution.

I propose that we do the check at build time instead and change the rc
script accordingly.  See the attached patch for an attempt to do this.

OSVERSION value from [1] by choosing the nearest date to [2].

[1] https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/versions-11.html
[2] https://github.com/freebsd/freebsd/commit/29a843a8a2e5e9eaf7dbbee4927bdf924dc25bfb#diff-1203c653568cb06d91b7935d75f319ae
Comment 8 Stefan Bethke 2017-10-28 14:34:35 UTC 
Happy to do it this way as well. I opted for shell to enable the logging options when the OS is upgraded, without the package being updated, but doing it from the build is fine by me.
Comment 9 commit-hook freebsd_committer freebsd_triage 2017-10-29 07:55:52 UTC 
A commit references this bug:

Author: tobik
Date: Sun Oct 29 07:55:34 UTC 2017
New revision: 453097
URL: https://svnweb.freebsd.org/changeset/ports/453097

Log:
  www/gitea: Fix rc script on FreeBSD 10.x/11.0

  On FreeBSD 10.x/11.0 daemon(8) doesn't have -s,-l,-t, so starting
  gitea would fail.  We partially revert the change from r453018 and use
  the old behavior on these versions and don't log stdout/stderr to
  syslog.

  PR:		223283
  Approved by:	stb@lassitu.de (maintainer)

Changes:
  head/www/gitea/Makefile
  head/www/gitea/files/gitea.in
Comment 10 Tobias Kortkamp freebsd_committer freebsd_triage 2017-10-29 07:56:29 UTC 
Committed. Thanks!