Created attachment 187883 [details] patch For the report see https://lists.freebsd.org/pipermail/freebsd-ports/2017-November/111008.html It refers to https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=828466 Testbuilds are fine, run-tests are needed.
> checking for library containing SSL_library_init... no During BSDCan 2018 the intention to update OpenSSL in base to 1.1.x branch was documented. Intention is to update 12-STABLE to current 1.1.0 and subsequently update it to 1.1.1 when that is released. The intent to update OpenSSL to 1.1 in 12 has now officially been documented in Bug #228912 Poudriere log: https://keg.brnrd.eu/data/111amd64-default-openssl110/2018-06-11_10h42m37s/logs/errors/opendkim-2.10.3_7.log
*** Bug 229028 has been marked as a duplicate of this bug. ***
re-running testbuild on 12a.
I tested the patch, but I see now a linker error: Making all in miltertest cc -DHAVE_CONFIG_H -I. -I.. -I./../libopendkim -I/usr/include -I/usr/local/include/lua52 -DCONFIG_BASE=\"/usr/local/etc\" -O2 -pipe -fstack-protector -fno-strict-aliasing -MT miltertest-miltertest.o -MD -MP -MF .deps/miltertest-miltertest.Tpo -c -o miltertest-miltertest.o `test -f 'miltertest.c' || echo './'`miltertest.c mv -f .deps/miltertest-miltertest.Tpo .deps/miltertest-miltertest.Po /bin/sh ../libtool --tag=CC --mode=link cc -O2 -pipe -fstack-protector -fno-strict-aliasing ../libopendkim/libopendkim.la -L/usr/local/lib/lua52 -Wl,-rpath,/usr/local/lib -fstack-protector -o miltertest miltertest-miltertest.o -llua -lm libtool: link: cc -O2 -pipe -fstack-protector -fno-strict-aliasing -Wl,-rpath -Wl,/usr/local/lib -fstack-protector -o .libs/miltertest miltertest-miltertest.o ../libopendkim/.libs/libopendkim.so -L/usr/local/lib -L/usr/local/lib/lua52 -llua -lm -lssl -lcrypto -Wl,-rpath -Wl,/usr/local/lib /usr/bin/ld: cannot find -llua cc: error: linker command failed with exit code 1 (use -v to see invocation) *** Error code 1 Stop. make[3]: stopped in /wrkdirs/usr/ports/mail/opendkim/work/opendkim-2.10.3/miltertest *** Error code 1 Full log is here: http://pkg.fechner.net/data/112amd64-default/2018-10-05_15h52m06s/logs/errors/opendkim-2.10.3_10.log
Created attachment 198070 [details] fix builds with openssl 1.1 A modification of Kurt's patch, which fixes building. (thanks for the help) As we now re-build configure, the pre-configure Makefile section had to be modified to patch the .ac file instead of configure. Poudriere testport logs for 10.4/11.2 i386/amd64 (and an 11.2 amd64 w/openssl 1.1) are at: https://poudriere.dan.tm/poudriere/data/latest-per-pkg/opendkim/2.10.3_11/ Patch builds on existing and -devel openssl.
I tested the patch and it works fine for me. Kurt will you commit it? (I'm only allowed to commit gitlab specific changes)
A commit references this bug: Author: mfechner Date: Sat Oct 20 10:19:30 UTC 2018 New revision: 482481 URL: https://svnweb.freebsd.org/changeset/ports/482481 Log: Fixed problems with OpenSSL 1.1.1 and an error message regarding lua. PR: 223568 Submitted by: freebsd-ports@dan.me.uk Reported by: pi@FreeBSD.org Reviewed by: mfechner@FreeBSD.org Approved by: mentors (implicit) Changes: head/mail/opendkim/Makefile head/mail/opendkim/files/patch-libopendkim__tests__Makefile.in head/mail/opendkim/files/patch-libopendkim_dkim-canon.c head/mail/opendkim/files/patch-opendkim__tests__Makefile.in
Thanks for the fix!
Hi Matthias, You missed out a couple of new files in the commit: files/patch-configure.ac files/patch-opendkim_opendkim-crypto.c Thanks, Daniel.
Dear Daniel, sry for this, added in 482484.
ports r482484
opendkim fails to configure in 12.0 quarterly due to this issue (as head did). ports r482481 fixed it in head, but it was not merged. Re-open to get this change merged.
Created attachment 200171 [details] http://beefy2.nyi.freebsd.org/data/120amd64-quarterly/487556/logs/errors/opendkim-2.10.3_9.log
(In reply to Kubilay Kocak from comment #12) via https://twitter.com/bensyverson/status/1074437101410758657
I think this problem with fixed with branch 2019Q1: https://pkg.fechner.net/data/120amd64-2019Q1/2019-01-07_12h57m01s/logs/opendkim-2.10.3_11.log
Missed merge window, ports r482481 is now in 2019Q1