Bug 223850 - [NEW PORT] science/ALPScore: Generic algorithms and utilities for condensed matter physics
Summary: [NEW PORT] science/ALPScore: Generic algorithms and utilities for condensed m...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL: https://reviews.freebsd.org/D13237
Keywords:
Depends on:
Blocks:
 
Reported: 2017-11-24 19:40 UTC by Anonymized Account
Modified: 2017-12-03 19:29 UTC (History)
1 user (show)

See Also:


Attachments
science/ALPSCore-* (9.63 KB, patch)
2017-11-24 19:40 UTC, Anonymized Account
no flags Details | Diff
science/ALPSCore-serial: portlint -AC (126 bytes, text/plain)
2017-11-24 19:41 UTC, Anonymized Account
no flags Details
science/ALPSCore-openmpi2: portlint -AC (267 bytes, text/plain)
2017-11-24 19:41 UTC, Anonymized Account
no flags Details
science/ALPSCore-serial: poudriere testport (411.74 KB, text/plain)
2017-11-24 19:42 UTC, Anonymized Account
no flags Details
science/ALPSCore-openmpi2: poudriere testport (51.14 KB, text/plain)
2017-11-24 19:42 UTC, Anonymized Account
no flags Details
science/ALPSCore-openmpi2: poudriere testport (484.98 KB, text/plain)
2017-11-24 20:25 UTC, Anonymized Account
no flags Details
Updated patch (8.57 KB, patch)
2017-11-25 00:06 UTC, Yuri Victorovich
no flags Details | Diff
Updated patch (8.57 KB, patch)
2017-11-25 00:08 UTC, Yuri Victorovich
no flags Details | Diff
Updated patch (9.18 KB, patch)
2017-11-25 01:28 UTC, Yuri Victorovich
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anonymized Account freebsd_committer freebsd_triage 2017-11-24 19:40:58 UTC
Created attachment 188244 [details]
science/ALPSCore-*

/!\ CAVEAT EMPTOR /!\
I am not really sure whether I should set CMAKE_*_COMPILER_LAUNCHER, because poudriere mentions symlinking ccache for the the compilers -- so mpi wrappers would already use it. Is that the case with direct build from ports, too?

The open source ALPSCore project, which is based on ALPS (Algorithms and
Libraries for Physics Simulations) project, provides a collection of physics
libraries and applications, with a focus on simulations of lattice models and
strongly correlated systems. This project strives to provide a convenient set of
maintained, well-documented, and reusable components for developing condensed
matter physics simulation code, to help application developers make commonly
used and proven computational algorithms available to a non-expert community.

WWW: https://github.com/ALPSCore/ALPSCore
Comment 1 Anonymized Account freebsd_committer freebsd_triage 2017-11-24 19:41:34 UTC
Created attachment 188245 [details]
science/ALPSCore-serial: portlint -AC
Comment 2 Anonymized Account freebsd_committer freebsd_triage 2017-11-24 19:41:57 UTC
Created attachment 188246 [details]
science/ALPSCore-openmpi2: portlint -AC
Comment 3 Anonymized Account freebsd_committer freebsd_triage 2017-11-24 19:42:21 UTC
Created attachment 188247 [details]
science/ALPSCore-serial: poudriere testport
Comment 4 Anonymized Account freebsd_committer freebsd_triage 2017-11-24 19:42:44 UTC
Created attachment 188248 [details]
science/ALPSCore-openmpi2: poudriere testport
Comment 5 Anonymized Account freebsd_committer freebsd_triage 2017-11-24 19:45:10 UTC
Comment on attachment 188248 [details]
science/ALPSCore-openmpi2: poudriere testport

Whoops.
Comment 6 Anonymized Account freebsd_committer freebsd_triage 2017-11-24 20:25:01 UTC
Created attachment 188251 [details]
science/ALPSCore-openmpi2: poudriere testport
Comment 7 Yuri Victorovich freebsd_committer freebsd_triage 2017-11-24 21:17:09 UTC
Thanks for your submission!

In the future, you don't need to attach portlint/poudriere logs. It's sufficient to just say that they pass.
Comment 8 Anonymized Account freebsd_committer freebsd_triage 2017-11-24 21:24:44 UTC
Hi,

Thanks, will stop uploading. I vaguely remember them being required some time ago?

Cheers,
Mike
Comment 9 Yuri Victorovich freebsd_committer freebsd_triage 2017-11-24 21:29:58 UTC
(In reply to Michael Danilov from comment #8)

Opinions can vary, but I think that people who regularly submit ports are considered trustworthy, therefore there should be enough to just say it. I did this for a long time without problems. Committer has to rerun it anyways.

Thanks!
Yuri
Comment 10 Yuri Victorovich freebsd_committer freebsd_triage 2017-11-24 21:49:53 UTC
I think, I will merge ALPSCore-openmpi2 into ALPSCore-serial, and make openmpi2/serial port options, since they can't be installed at the same time.
Comment 11 Anonymized Account freebsd_committer freebsd_triage 2017-11-24 22:03:07 UTC
Buy I heard that with port options one can't have both available in the binary repo?
Comment 12 Yuri Victorovich freebsd_committer freebsd_triage 2017-11-24 22:05:27 UTC
(In reply to Michael Danilov from comment #11)

There is an upcoming 'package flavor' patch that will make possible to have both. I am not sure how exactly, but they are working on this.

Yuri
Comment 13 Anonymized Account freebsd_committer freebsd_triage 2017-11-24 22:12:44 UTC
Then go ahead.

What about ccache? Should those args be passed to cmake?
Comment 14 Yuri Victorovich freebsd_committer freebsd_triage 2017-11-24 22:21:09 UTC
(In reply to Michael Danilov from comment #13)

ccache was broken when I tried it last time: https://github.com/ccache/ccache/issues/200

They need to fix it before we can use it.
Comment 15 Yuri Victorovich freebsd_committer freebsd_triage 2017-11-24 23:26:19 UTC
(In reply to Michael Danilov from comment #13)

I'll remove the ccache part. It seems this should be set by the framework in Mk/, not by individual ports. It only improves the speed of build, and not the final result.
Comment 16 Anonymized Account freebsd_committer freebsd_triage 2017-11-24 23:39:36 UTC
(In reply to Yuri Victorovich from comment #15)

Go ahead. If ccache is not used building without poudriere, the solution to the problem should belong to Mk.
Comment 17 Yuri Victorovich freebsd_committer freebsd_triage 2017-11-25 00:06:25 UTC
Created attachment 188258 [details]
Updated patch

My current version.
Comment 18 Yuri Victorovich freebsd_committer freebsd_triage 2017-11-25 00:08:48 UTC
Created attachment 188259 [details]
Updated patch
Comment 19 Yuri Victorovich freebsd_committer freebsd_triage 2017-11-25 01:28:46 UTC
Created attachment 188263 [details]
Updated patch

Normally build w/outs tests.
Tests are build only for the test target.
Disabled the documentation option because it is broken.
Comment 20 Anonymized Account freebsd_committer freebsd_triage 2017-11-28 13:41:30 UTC
Comment on attachment 188263 [details]
Updated patch

Looks good, thank you!
Comment 21 Anonymized Account freebsd_committer freebsd_triage 2017-11-28 15:07:36 UTC
Oh, and maybe there is a way to disable individual tests in CMake? Should I try to comment them out with a patchfile?
Comment 22 Yuri Victorovich freebsd_committer freebsd_triage 2017-11-28 17:10:55 UTC
(In reply to Michael Danilov from comment #21)

The current patch disables tests during build.
Comment 23 Anonymized Account freebsd_committer freebsd_triage 2017-11-28 17:23:51 UTC
Yes, I'm asking if we could maybe keep the tests running and exclude the failing ones?
Comment 24 Yuri Victorovich freebsd_committer freebsd_triage 2017-11-28 17:52:25 UTC
(In reply to Michael Danilov from comment #23)

Ah, I see. Maybe, but that's the point of tests to show it when some are failing?
IMO, all tests should run unless they are legitimately waived, like when they don't apply or something.
Currently, one failure is unexpected, the rest are known failures.
https://github.com/ALPSCore/ALPSCore/issues/388#issuecomment-346971059
Comment 25 Yuri Victorovich freebsd_committer freebsd_triage 2017-12-03 19:29:20 UTC
Committed with changes.

Thank you for your contribution!
Comment 26 commit-hook freebsd_committer freebsd_triage 2017-12-03 19:29:55 UTC
A commit references this bug:

Author: yuri
Date: Sun Dec  3 19:29:13 UTC 2017
New revision: 455424
URL: https://svnweb.freebsd.org/changeset/ports/455424

Log:
  New port: science/ALPSCore: Generic algorithms and utilities for condensed matter physics

  PR:		223850
  Submitted by:	Michael Danilov <mike.d.ft402@gmail.com>
  Approved by:	tcberner (mentor)
  Differential Revision:	https://reviews.freebsd.org/D13237

Changes:
  head/science/ALPSCore/
  head/science/ALPSCore/Makefile
  head/science/ALPSCore/distinfo
  head/science/ALPSCore/pkg-descr
  head/science/ALPSCore/pkg-plist
  head/science/Makefile