Bug 224656 - devel/subversion: stage-qa failure due to use of python2 in python_CMD
Summary: devel/subversion: stage-qa failure due to use of python2 in python_CMD
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Lev A. Serebryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-12-28 21:08 UTC by Phillip R. Jaenke
Modified: 2018-01-04 20:59 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (lev)


Attachments
devel_subversion.Makefile.patch (549 bytes, text/plain)
2017-12-28 21:08 UTC, Phillip R. Jaenke
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Phillip R. Jaenke 2017-12-28 21:08:25 UTC
Created attachment 189175 [details]
devel_subversion.Makefile.patch

===> Staging rc.d startup script(s)
*** Error code 1 (ignored)
===========================================================================
====> Running Q/A tests (stage-qa)
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/dist/collect_sigs.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/dist/checksums.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/dist/release.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/dist/backport_tests.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/bdb/svn-bdb-view.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/bdb/erase-all-text-data.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/bdb/whatis-rep.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/examples/blame.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/examples/putfile.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/examples/geturl.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/examples/walk-config-auth.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/examples/dumpprops.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/examples/SvnCLBrowse'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/examples/get-location-segments.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/examples/svnshell.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/examples/check-modified.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/examples/revplist.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/examples/svnlook.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/examples/getfile.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/po/l10n-report.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/hook-scripts/validate-extensions.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/hook-scripts/control-chars.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/hook-scripts/mailer/tests/mailer-tweak.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/hook-scripts/mailer/mailer.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/hook-scripts/validate-files.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/hook-scripts/svn2feed.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/hook-scripts/svnperms.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/hook-scripts/log-police.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/hook-scripts/persist-ephemeral-txnprops.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/hook-scripts/verify-po.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/server-side/svn_server_log_parse.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/server-side/svnpubsub/svnwcsub.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/server-side/svnpubsub/irkerbridge.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/server-side/svnpubsub/watcher.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/server-side/svnpubsub/svntweet.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/server-side/svnpubsub/testserver.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/server-side/svnpubsub/commit-hook.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/server-side/svnpubsub/revprop-change-hook.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/server-side/test_svn_server_log_parse.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/server-side/svnpredumpfilter.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/server-side/fsfs-reshard.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/server-side/svn-backup-dumps.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/dev/which-error.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/dev/lock-check.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/dev/contribulyze.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/dev/po-merge.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/dev/analyze-svnlogs.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/dev/trails.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/dev/gen_junit_report.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/dev/datecheck.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/dev/gen-py-errors.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/dev/benchmarks/suite1/benchmark.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/dev/random-commits.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/dev/svn-merge-revs.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/dev/normalize-dump.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/dev/wc-format.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/dev/check-license.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/dev/sbox-ospath.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/dev/iz/find-fix.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/dev/iz/ff2csv.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/dev/mklog.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/dev/merge-graph.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/dev/mlpatch.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/dev/find-bad-style.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/dev/log_revnum_change_asf.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/dev/histogram.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/dev/graph-dav-servers.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/dev/scramble-tree.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/dev/wc-ng/graph-data.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/dev/wc-ng/bump-to-19.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/dev/wc-ng/count-progress.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/dev/wc-ng/populate-pristine.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/dev/verify-history.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/dev/gen-javahl-errors.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/backup/hot-backup.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/client-side/mergeinfo-sanitizer.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/client-side/server-version.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/client-side/svn-viewspec.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/client-side/svn-vendor.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/client-side/detach.py'
Error: '/usr/local/bin/python2' is an invalid shebang you need USES=shebangfix for 'share/subversion/client-side/change-svn-wc-format.py'
Warning: 'bin/x509-parser' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
*** Error code 1

Appears to be more flavors fallout and use of 'python2' rather than the more explicit 'python2.7' and not being updated to flavors. Tested patch successfully in my environment.
Comment 1 Po-Chuan Hsieh freebsd_committer freebsd_triage 2017-12-29 21:17:43 UTC
If you just want to fix shebang, you probably want to use "python:env" instead to avoid adding python as a dependency.
And python_OLD_CMD+= can be changed to python_OLD_CMD.
The following patch also fixes indent.

Index: devel/subversion/Makefile
===================================================================
--- devel/subversion/Makefile   (revision 457505)
+++ devel/subversion/Makefile   (working copy)
@@ -41,10 +41,9 @@
 FREEBSD_TEMPLATE_EXTRA_PATCHES=        ${PATCHDIR}/extra-patch-fbsd-template
 SVNSERVE_WRAPPER_EXTRA_PATCHES=        ${PATCHDIR}/extra-patch-svnserve-wrapper

-USES+=                 shebangfix
-python_CMD=            ${LOCALBASE}/bin/python2
-python_OLD_CMD+=       "/bin/env python"
-SHEBANG_REGEX=         ./tools/.*
+USES+=         shebangfix python:2.7,env
+python_OLD_CMD=        "/bin/env python"
+SHEBANG_REGEX= ./tools/.*

 .include "Makefile.common"
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-01-04 20:59:28 UTC
A commit references this bug:

Author: lev
Date: Thu Jan  4 20:58:50 UTC 2018
New revision: 458087
URL: https://svnweb.freebsd.org/changeset/ports/458087

Log:
   Fix python shebangs

  PR:		224656
  Submitted by:	Phillip R. Jaenke

Changes:
  head/devel/subversion/Makefile
Comment 3 Lev A. Serebryakov freebsd_committer freebsd_triage 2018-01-04 20:59:58 UTC
Committed, thanks!