Bug 224879 - exp-run FLAVORS helpers fix
Summary: exp-run FLAVORS helpers fix
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Port Management Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-03 23:29 UTC by Bryan Drewery
Modified: 2018-01-08 00:26 UTC (History)
1 user (show)

See Also:
antoine: exp-run+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Antoine Brodin freebsd_committer freebsd_triage 2018-01-06 19:50:06 UTC 
Exp-run looks fine.
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-01-08 00:25:19 UTC 
A commit references this bug:

Author: bdrewery
Date: Mon Jan  8 00:24:49 UTC 2018
New revision: 458394
URL: https://svnweb.freebsd.org/changeset/ports/458394

Log:
  Fix flavor helpers when only bsd.port.pre.mk is not used and FLAVOR is not set.

  The helpers were being evaluated before the default FLAVOR was set. The
  helpers worked fine if the FLAVOR was specified by the user but not if
  it was left to the default value. Resolve this by moving the helpers
  right after the default FLAVOR is set.

  PR:		224879
  exp-run by:	antoine
  Approved by:	portmgr (implicit)
  MFH:		2018Q1
  Differential Revision:	https://reviews.freebsd.org/D13756

Changes:
  head/Mk/bsd.port.mk
Comment 3 commit-hook freebsd_committer freebsd_triage 2018-01-08 00:26:22 UTC 
A commit references this bug:

Author: bdrewery
Date: Mon Jan  8 00:25:28 UTC 2018
New revision: 458395
URL: https://svnweb.freebsd.org/changeset/ports/458395

Log:
  MFH: r458394

  Fix flavor helpers when only bsd.port.pre.mk is not used and FLAVOR is not set.

  The helpers were being evaluated before the default FLAVOR was set. The
  helpers worked fine if the FLAVOR was specified by the user but not if
  it was left to the default value. Resolve this by moving the helpers
  right after the default FLAVOR is set.

  PR:		224879
  exp-run by:	antoine
  Approved by:	portmgr (implicit)
  Differential Revision:	https://reviews.freebsd.org/D13756

Changes:
_U  branches/2018Q1/
  branches/2018Q1/Mk/bsd.port.mk