Bug 225143 - [maintainer update] x11-themes/xfce-evolution update to 4.3.1 (was to 4.0.0, 4.1.0)
Summary: [maintainer update] x11-themes/xfce-evolution update to 4.3.1 (was to 4.0.0, ...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Thomas Zander
URL:
Keywords: needs-patch, needs-qa, patch
Depends on:
Blocks:
 
Reported: 2018-01-13 16:46 UTC by J.R. Oldroyd
Modified: 2018-02-17 20:10 UTC (History)
2 users (show)

See Also:


Attachments
patch to update from 3.1.9 to 4.0.0 (180.57 KB, patch)
2018-01-13 16:46 UTC, J.R. Oldroyd
no flags Details | Diff
patch to update from 3.1.9 to 4.0.0 (patch version 2) (185.94 KB, patch)
2018-01-14 17:44 UTC, J.R. Oldroyd
no flags Details | Diff
patch to update from 3.1.9 to 4.0.0 (patch version 3) (186.00 KB, patch)
2018-01-15 16:35 UTC, J.R. Oldroyd
no flags Details | Diff
patch to update from 3.1.9 to 4.1.0 (187.16 KB, patch)
2018-01-31 22:29 UTC, J.R. Oldroyd
fbsd: maintainer-approval+
Details | Diff
patch to update from 3.1.9 to 4.3.1 (201.92 KB, patch)
2018-02-11 16:18 UTC, J.R. Oldroyd
fbsd: maintainer-approval+
Details | Diff
patch #2 to update from 3.1.9 to 4.3.1 (201.88 KB, patch)
2018-02-17 19:19 UTC, J.R. Oldroyd
fbsd: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description J.R. Oldroyd 2018-01-13 16:46:52 UTC
Created attachment 189687 [details]
patch to update from 3.1.9 to 4.0.0
Comment 1 J.R. Oldroyd 2018-01-14 17:44:30 UTC
Created attachment 189713 [details]
patch to update from 3.1.9 to 4.0.0 (patch version 2)
Comment 2 J.R. Oldroyd 2018-01-15 16:35:21 UTC
Created attachment 189752 [details]
patch to update from 3.1.9 to 4.0.0 (patch version 3)
Comment 3 J.R. Oldroyd 2018-01-31 22:29:18 UTC
Created attachment 190235 [details]
patch to update from 3.1.9 to 4.1.0

Since 4.0.0 has not yet been committed, I am superseding it with this patch from the current 3.1.9 straight to 4.1.0.
Comment 4 J.R. Oldroyd 2018-02-11 16:18:22 UTC
Created attachment 190514 [details]
patch to update from 3.1.9 to 4.3.1

A further update is available, now to 4.3.1.  Any committers out there?
Comment 5 Tobias C. Berner freebsd_committer freebsd_triage 2018-02-11 20:21:30 UTC
Moin moin


Why did you remove the post-extract target that replaced the whitespaces with dashes?


mfg Tobias
Comment 6 J.R. Oldroyd 2018-02-11 21:02:30 UTC
Because the various theme "Xfce Evolution Xyz" css files now reference a single copy of the assets in the common "Xfce Evolution" directory.  Previously, they each had their own copy of the assets.  It stopped working because I had changed the FreeBSD installation path to have those "-" characters (which I did thinking the spaces would cause problems when, in fact, they don't really).
Comment 7 Thomas Zander freebsd_committer freebsd_triage 2018-02-17 16:04:17 UTC
This won't work (from Makefile):

       @${LN} -s ${STAGEDIR}${PREFIX}/share/themes/Xfce\ Evolution/90-qt5.conf ${STAGEDIR}/${PREFIX}/etc/fonts/conf.avail/90-qt5.conf
        @${LN} -s ${STAGEDIR}${PREFIX}/etc/fonts/conf.avail/90-qt5.conf ${STAGEDIR}/${PREFIX}/etc/fonts/conf.d/90-qt5.conf

It causes the symlink target to point inside a built-time dependent temporary folder in STAGEDIR. Hence you get an error message from stage-qa:

====> Running Q/A tests (stage-qa)
Error: Bad symlink 'etc/fonts/conf.d/90-qt5.conf' pointing inside the stage directory
Error: Bad symlink 'etc/fonts/conf.avail/90-qt5.conf' pointing inside the stage directory
*** Error code 1

Stop.
make: stopped in /usr/ports/x11-themes/xfce-evolution

Could you try using relative symlinks to avoid this problem?
While you are on it, you might want to pet portlint and replace "rm" with "${RM}" in Makefile.
Comment 8 J.R. Oldroyd 2018-02-17 19:19:09 UTC
Created attachment 190737 [details]
patch #2 to update from 3.1.9 to 4.3.1

OK, sorry about that.  Both fixed in the new patch.
Comment 9 commit-hook freebsd_committer freebsd_triage 2018-02-17 20:05:11 UTC
A commit references this bug:

Author: riggs
Date: Sat Feb 17 20:04:40 UTC 2018
New revision: 462191
URL: https://svnweb.freebsd.org/changeset/ports/462191

Log:
  Update to upstream release 4.3.1

  PR:		225143
  Submitted by:	fbsd@opal.com (maintainer)

Changes:
  head/x11-themes/xfce-evolution/Makefile
  head/x11-themes/xfce-evolution/distinfo
  head/x11-themes/xfce-evolution/pkg-plist
Comment 10 Thomas Zander freebsd_committer freebsd_triage 2018-02-17 20:10:10 UTC
Thanks for handling this so quickly!