Bug 225445 - lang/rust: fails stage-qa and check-plist
Summary: lang/rust: fails stage-qa and check-plist
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jean-Sébastien Pédron
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2018-01-25 09:37 UTC by Jan Beich
Modified: 2018-01-25 14:02 UTC (History)
1 user (show)

See Also:
dumbbell: maintainer-feedback+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2018-01-25 09:37:30 UTC
After 1.23 update the port fails "poudriere bulk -t" or "poudriere testport".

====> Running Q/A tests (stage-qa)
Error: 'lib/rustlib/manifest-rustfmt-preview' is referring to /wrkdirs/usr/ports/lang/rust/work/stage
[...]
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: bin/rustfmt
Error: Orphaned: lib/rustlib/manifest-rustfmt-preview

build log: https://clbin.com/BLKTP
Comment 1 Jan Beich freebsd_committer freebsd_triage 2018-01-25 09:39:50 UTC
PORTTESTING_FATAL=no in poudriere.conf can be a workaround.
Comment 2 Jean-Sébastien Pédron freebsd_committer freebsd_triage 2018-01-25 10:55:35 UTC
Hmm, I did many runs in Poudriere with various versions of FreeBSD before committing. I must be missing something in my QA procedure because I didn't get this error.

Let me try again with the command line you used.
Comment 3 Jean-Sébastien Pédron freebsd_committer freebsd_triage 2018-01-25 12:46:55 UTC
Ok, I could reproduce the problem.

I'm using `poudriere bulk ... -C lang/rust www/firefox` to test packages instead of `poudriere testport` in order to be able to used the created package repository after.

With `poudriere testport`, I got the errors about `rustfmt` and `manifest-rustfmt-preview`.
Comment 4 commit-hook freebsd_committer freebsd_triage 2018-01-25 13:59:45 UTC
A commit references this bug:

Author: dumbbell
Date: Thu Jan 25 13:59:23 UTC 2018
New revision: 459943
URL: https://svnweb.freebsd.org/changeset/ports/459943

Log:
  lang/rust: Add manifest-rustfmt-preview to PLIST

  This wasn't reported by a simple `poudriere bulk`, but a `poudriere
  testport` revealed the problem:

      ====> Running Q/A tests (stage-qa)
      Error: 'lib/rustlib/manifest-rustfmt-preview' is referring to /wrkdirs/usr/ports/lang/rust/work/stage
      Warning: 'bin/rustfmt' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
      ...
      ===> Checking for items in STAGEDIR missing from pkg-plist
      Error: Orphaned: bin/rustfmt
      Error: Orphaned: lib/rustlib/manifest-rustfmt-preview

  PR:		225445
  Reported by:	jbeich@

Changes:
  head/lang/rust/Makefile
Comment 5 Jean-Sébastien Pédron freebsd_committer freebsd_triage 2018-01-25 14:02:45 UTC
It's fixed now. Thanks for reporting the issue!