Bug 225607 - misc/sent: Update to version 1
Summary: misc/sent: Update to version 1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-02-01 16:50 UTC by Mateusz Piotrowski
Modified: 2018-02-02 04:06 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (nc)

Attachments
A patch updating misc/sent to version 1 (4.12 KB, patch)
2018-02-01 16:50 UTC, Mateusz Piotrowski 		no flags Details | Diff
sent.diff (3.33 KB, patch)
2018-02-01 17:47 UTC, Tobias Kortkamp 		nc: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mateusz Piotrowski freebsd_committer freebsd_triage 2018-02-01 16:50:25 UTC 
Created attachment 190248 [details]
A patch updating misc/sent to version 1

* Update to version 1 from 0.2.
 * Change license to ISCL.
 * Remove libpng from LIB_DEPENDS (version 1 is no longer using it).
 * Add a run-time dependecy: 2ff from graphics/farbfeld.
 * Add DOCS and EXAMPLES options.
 * Add new files to examples.
 * Add README.md to docs.
 * Change ALL_TARGET to 'install' in order to install a manpage as well.
 * Add MAKE_ARGS to fix the path for manpages (MAKE_ARGS are inspired by MAKE_ARGS from x11-wm/dwm/Makefile).
 * Extract to WRKSRC as the port's distribution does not unpack to WRKSRC by default.
 * Strip `sent`.
 * Update distinfo.
 * Update the 'config.mk' patch in order to use FreeBSD-specific settings from  upstream. Also, remove the -g flag from the default CFLAGS and LDFLAGS.

Changes: 
 * https://git.suckless.org/sent/log/

Tests:
 * `portlint` is fine.
 * Manual installation and deinstallation works just fine.
 * `port test` passes but it produce a couple of (warning?) messages like this:
  
  > actual-package-depends: dependency on /usr/local/libdata/pkgconfig/x11.pc not registered (normal if it belongs to base)

  Unfortunately, similar messages are generated for misc/sent version 0.2 and x11-wm/dwm. It looks like it is a problem related to the way me port software from suckless.org. I wasn't able to troubleshot it though.
Comment 1 Tobias Kortkamp freebsd_committer freebsd_triage 2018-02-01 17:47:52 UTC 
Created attachment 190250 [details]
sent.diff

Thank you Mateusz.  Unfortunately the patch didn't apply properly
(problems in config.mk).  Here's an updated patch that also fixes some
other problems.

- Removing -g CFLAGS is not really necessary when you're stripping the
  binary in post-install

- We have NO_WRKSUBDIR for distfiles that don't extract to a proper
  subdirectory

Poudriere testport on 10.3/i386 and 11.1/amd64 were ok
Comment 2 Mateusz Piotrowski freebsd_committer freebsd_triage 2018-02-01 19:17:42 UTC 
(In reply to Tobias Kortkamp from comment #1)

Thanks, Tobias. I'll remember to try out the patch on a fresh port next time.
Comment 3 Neel Chauhan freebsd_committer freebsd_triage 2018-02-01 21:02:55 UTC 
Looks fine.
Comment 4 Tobias Kortkamp freebsd_committer freebsd_triage 2018-02-02 04:06:40 UTC 
Committed, thanks!
Comment 5 commit-hook freebsd_committer freebsd_triage 2018-02-02 04:06:44 UTC 
A commit references this bug:

Author: tobik
Date: Fri Feb  2 04:06:07 UTC 2018
New revision: 460664
URL: https://svnweb.freebsd.org/changeset/ports/460664

Log:
  misc/sent: Update to 1

  Changes:	https://git.suckless.org/sent/log/?h=1
  PR:		225607
  Submitted by:	Mateusz Piotrowski <mpp302@gmail.com> (based on)
  Approved by:	Neel Chauhan <neel@neelc.org> (maintainer)

Changes:
  head/misc/sent/Makefile
  head/misc/sent/distinfo
  head/misc/sent/files/patch-config.mk