Created attachment 190264 [details] Proposed patch Instead of using "stable" and just update the checksum following the changes, pin the version of the tarball should be a better solution. Otherwise, the checksum will be obsolescence when a new stable release comes out (see the current broken port for example). https://dl.equinox.io/ngrok/ngrok/stable/archive
Looks good to me
Looks fine here. Feel free to add in (or not) the stuff below at your own discretion. Usually, when introducing things that will change on every release, it's customary to break it out into separate variables. Just makes it easier to maintain. ... ${ARCH:S/i386/${i386_HASH}} i386_HASH= [...] amd64_HASH= [...] Also why is this putting files into ${PORTNAME}/${PORTVERSION}? That's not really how we do distfiles.
Oh! Sorry, it just clicked. Because the distfile's name doesn't change. Right. My apologies.
Created attachment 191125 [details] Proposed patch updated
Please re-approve the patch so I can commit. Updated to newest version, also switch to use .tar.gz archives.
It looks pretty good, but I think I agree with adamw: Now that the DISTFILE filename does include the version string, I think we should no longer need to set DIST_SUBDIR. Do you agree? Obviously, this change (if adopted) would also need the distinfo to be regenerated and port build to be re-tested.
(In reply to Ben Woods from comment #6) Right on, I agree about setting DIST_SUBDIR back to default. I will do the testing and post up-to-date patches to Phabricator for review. Thanks!
LGTM
Ping. Have you had a chance to look at this one again Guangyuan? Should be a quick fix :)
Any news? This port expired on 2020-05-05.
A commit references this bug: Author: rene Date: Sun Jun 7 18:28:53 UTC 2020 New revision: 538182 URL: https://svnweb.freebsd.org/changeset/ports/538182 Log: security/ngrok: fix fetch, unexpire, bump PORTREVISION PR: 225622 Submitted by: ygy Approved by: maintainer (jhixson) MFH: 2020Q2 Changes: head/security/ngrok/Makefile head/security/ngrok/distinfo
A commit references this bug: Author: rene Date: Mon Jun 8 13:23:04 UTC 2020 New revision: 538216 URL: https://svnweb.freebsd.org/changeset/ports/538216 Log: MFH: r538182 security/ngrok: fix fetch, unexpire, bump PORTREVISION PR: 225622 Submitted by: ygy Approved by: maintainer (jhixson) Approved by: ports-secteam (joneum) Changes: _U branches/2020Q2/ branches/2020Q2/security/ngrok/Makefile branches/2020Q2/security/ngrok/distinfo