Created attachment 190406 [details] mail/py-afew-1.3.0.patch See https://github.com/afewmail/afew/releases/tag/1.3.0 for the release notes. Most importantly mail/py-dkimpy is a new dependency while devel/py-subprocess32 is no longer needed. Furthermore the format of the installed documentation was changed from manual pages to HTML. While a manpage is usually preferable the one generated by Sphinx doesn't fit the manpage format at all and isn't very readable. HTML is a much better fit for afew's documentation. Hence the MANPAGES option was renamed to DOCS.
For this port to work with Python 3 the dependency mail/py-dkimpy has to be updated (see bug #225742).
Sebastian, Why did you remove this .if clause? > .if ${PYTHON_REL} < 3000 > RUN_DEPENDS+= ${PYTHON_PKGNAMEPREFIX}subprocess32>=0:devel/py-subprocess32 > .endif Yuri
Because the dependency on subprocess32 was removed by upstream in the new release: - https://github.com/afewmail/afew/issues/64 - https://github.com/afewmail/afew/pull/164
(In reply to Sebastian Schwarz from comment #3) But it is still referenced in the code: > $ grep -r subprocess work-py27/ > work-py27/afew-1.3.0/afew/MailMover.py:from subprocess import check_call, CalledProcessError
Those are import from Python's standard library not from the subprocess32 compatibility library: - https://docs.python.org/2/library/subprocess.html#subprocess.check_call - https://docs.python.org/2/library/subprocess.html#subprocess.CalledProcessError - https://docs.python.org/3/library/subprocess.html#subprocess.check_call - https://docs.python.org/3/library/subprocess.html#subprocess.CalledProcessError
Hm, Python 2's documentation recommends to use subprocess32: https://docs.python.org/2/library/subprocess.html#module-subprocess Should we patch the port to do that, or assume the single call to subprocess.check_call is safe in that situation?
Docs fail: https://github.com/afewmail/afew/issues/184
I created a pull request with the fixes for upstream: https://github.com/afewmail/afew/pull/185 The patch applies cleanly to 1.3.0 as well and can be included in the port.
Sebastian, Sorry that I closed the review for this item. It is in my queue, I hope to get to it this week. It has proved easier to check and commit port from a patch, rather than to deal with reviews. Will get to it soon. Regards, Yuri
Committed with some changes. Thank you for the update!
A commit references this bug: Author: yuri Date: Tue Apr 3 07:17:09 UTC 2018 New revision: 466282 URL: https://svnweb.freebsd.org/changeset/ports/466282 Log: mail/py-afew: Update 1.2.0 -> 1.3.0 Port changes: * Minor correction in COMMENT * Add LICENSE_FILE * Update RUN_DEPENDS * Add USE_PYTHON=noflavors * Add NO_ARCH * Add DOCS option * Add the patch fixing docs build PR: 225743 Submitted by: Sebastian Schwarz <seschwar@gmail.com> (maintainer) Changes: head/mail/py-afew/Makefile head/mail/py-afew/distinfo
(In reply to Yuri Victorovich from comment #9) > It is in my queue, I hope to get to it this week. No worries. As I said, I do understand that people lead busy lives. :) > It has proved easier to check and commit port from a patch, rather than to deal > with reviews. Ok. I assumed a Phabricator review would be easier when giving feedback. Thanks for taking care of this.