Bug 226107 - typo in comment of function tdq_runq_add in sched_ule.c
Summary: typo in comment of function tdq_runq_add in sched_ule.c
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: Mark Johnston
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-02-22 05:03 UTC by Kunhui Lin
Modified: 2022-11-04 05:02 UTC (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kunhui Lin 2018-02-22 05:03:47 UTC 
change

/*
 * This queue contains only priorities between MIN and MAX
 * realtime.  Use the whole queue to represent these values.
 */

to

/*
 * This queue contains only priorities between MIN and MAX
 * timeshare.  Use the whole queue to represent these values.
 */

The queue the comment refers is tdq_timeshare.
Comment 1 Ed Maste freebsd_committer freebsd_triage 2021-12-01 14:13:49 UTC 
It's actually >= PRI_MIN_BATCH and <= PRI_MAX_BATCH, and PRI_MIN_BATCH is PRI_MIN_TIMESHARE + PRI_INTERACT_RANGE, so it's not MIN and MAX timeshare either. I think both the comment and code warrant some more consideration.
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-07-11 19:59:51 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=ba71333f6049ee76b0023b3b9e8444d5ccb1a7ff

commit ba71333f6049ee76b0023b3b9e8444d5ccb1a7ff
Author:     Mark Johnston <markj@FreeBSD.org>
AuthorDate: 2022-07-11 19:33:20 +0000
Commit:     Mark Johnston <markj@FreeBSD.org>
CommitDate: 2022-07-11 19:58:43 +0000

    sched_ule: Fix a typo in a comment

    PR:             226107
    MFC after:      1 week

 sys/kern/sched_ule.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-07-18 13:22:05 UTC 
A commit in branch stable/13 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=8342f4b1ef973f44813ee9720d290dc257ddfc48

commit 8342f4b1ef973f44813ee9720d290dc257ddfc48
Author:     Mark Johnston <markj@FreeBSD.org>
AuthorDate: 2022-07-11 19:33:20 +0000
Commit:     Mark Johnston <markj@FreeBSD.org>
CommitDate: 2022-07-18 13:08:16 +0000

    sched_ule: Fix a typo in a comment

    PR:             226107

    (cherry picked from commit ba71333f6049ee76b0023b3b9e8444d5ccb1a7ff)

 sys/kern/sched_ule.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 4 Mark Johnston freebsd_committer freebsd_triage 2022-07-18 13:22:40 UTC 
Thanks for the report.
Comment 5 Daniel Williams 2022-11-04 05:02:48 UTC 
MARKED AS SPAM