Bug 226347 - [NEW PORT] net/nostt: command line NOS Teletekst reader
Summary: [NEW PORT] net/nostt: command line NOS Teletekst reader
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-04 15:22 UTC by Sijmen J. Mulder
Modified: 2018-03-04 19:11 UTC (History)
1 user (show)

See Also:

Attachments
add net/nostt to ports tree (1.79 KB, patch)
2018-03-04 15:22 UTC, Sijmen J. Mulder 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sijmen J. Mulder 2018-03-04 15:22:03 UTC 
Created attachment 191200 [details]
add net/nostt to ports tree

Attached patch adds net/nostt to the tree (I'm the author of that tool).

This is my first port. Tried my best to follow the handbook and produce a good port, but there may be beginner mistakes.

Note that nostt's Makefile does not provide install/uninstall targets, so the port overrides the do-install target.
Comment 1 Sijmen J. Mulder 2018-03-04 15:24:00 UTC 
PS, the reason I've used MASTER_SITES even though it's on GitHub and I could've used GH_... is that this points to the manually uploaded source tarball rather than the GitHub-generated one.
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2018-03-04 19:07:08 UTC 
Ideally, the project Makefile should have the 'install' target that installs into $(DESTDIR)/$(PREFIX).

Also the first two lines of in Makefile should look like:
> CFLAGS  += -I$(PREFIX)/include -Wall -Wextra
> LDFLAGS  += -L$(PREFIX)/lib -lcurl -ljson-c

Then USES=localbase:ldflags and do-install will not be needed.

Yuri
Comment 3 Yuri Victorovich freebsd_committer freebsd_triage 2018-03-04 19:11:39 UTC 
Committed with changes. Port name: multimedia/nostt.
Thank you for your contribution!
Comment 4 commit-hook freebsd_committer freebsd_triage 2018-03-04 19:11:53 UTC 
A commit references this bug:

Author: yuri
Date: Sun Mar  4 19:11:34 UTC 2018
New revision: 463596
URL: https://svnweb.freebsd.org/changeset/ports/463596

Log:
  New port: multimedia/nostt: Command line NOS Teletekst reader, the Dutch public teletext system

  PR:		226347
  Submitted by:	Sijmen J. Mulder <ik@sjmulder.nl>
  Approved by:	tcberner (mentor, implicit)

Changes:
  head/multimedia/Makefile
  head/multimedia/nostt/
  head/multimedia/nostt/Makefile
  head/multimedia/nostt/distinfo
  head/multimedia/nostt/pkg-descr