Bug 226934 - [PATCH] deskutils/nextcloudclient needs @sample in plist
Summary: [PATCH] deskutils/nextcloudclient needs @sample in plist
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Michael Reifenberger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-26 08:00 UTC by Guido Falsi
Modified: 2018-04-10 14:04 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (mr)

Attachments
nextcloudclient patch (745 bytes, patch)
2018-03-26 08:00 UTC, Guido Falsi 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Guido Falsi freebsd_committer freebsd_triage 2018-03-26 08:00:21 UTC 
Created attachment 191823 [details]
nextcloudclient patch

Hi,

Thanks for creating a nextcloudclient port! Really much appreciated!

Starting it it fails saying it can't find the global exclude file. I discovered the port installs the sample but dies not create the actual file, which is expected to be there (PREFIX/etc/Nextcloud/sync-exclude.lst).

Attached patch adds @sample directive on the sample configuration which causes it to be copied to the actual file, if not already present

ref: https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/plist-config.html

In this way the installed port is ready to use without further (undocumented) installation steps.
Comment 1 commit-hook freebsd_committer freebsd_triage 2018-03-26 11:36:46 UTC 
A commit references this bug:

Author: mr
Date: Mon Mar 26 11:36:08 UTC 2018
New revision: 465581
URL: https://svnweb.freebsd.org/changeset/ports/465581

Log:
  Mark samples file as such.
  The port should work now after installation as is.

  PR:		226934
  Submitted by:	madpilot@

Changes:
  head/deskutils/nextcloudclient/Makefile
  head/deskutils/nextcloudclient/pkg-plist
Comment 2 Guido Falsi freebsd_committer freebsd_triage 2018-04-10 14:04:22 UTC 
Fixed by r465581