Bug 227326 - deskutils/parcellite: missing patch for build without NLS
Summary: deskutils/parcellite: missing patch for build without NLS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Guido Falsi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-06 17:01 UTC by guyyur
Modified: 2018-05-09 10:51 UTC (History)
2 users (show)

See Also:
madpilot: maintainer-feedback-

Attachments
extrapatch-configure.ac patch file (1.13 KB, patch)
2018-04-06 17:01 UTC, guyyur 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description guyyur 2018-04-06 17:01:22 UTC 
Created attachment 192291 [details]
extrapatch-configure.ac patch file

r394993 for bug 202537 removed files/extrapatch-configure.ac completely instead of just removing the extra diff copies inside the file.

This prevents the port from building when NLS option is not set.

See comment #4 in bug 202537 for the error.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=202537#c4

Attaching extrapatch-configure.ac based on the copy from before r394993 and trimmed to just one diff of configure.ac.
The file should be placed in deskutils/parcellite/files/
Comment 1 Guido Falsi freebsd_committer freebsd_triage 2018-05-09 10:36:56 UTC 
Taking, maintainer timed out.

This also classifies as "fixit" blanket.
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-05-09 10:49:56 UTC 
A commit references this bug:

Author: madpilot
Date: Wed May  9 10:49:04 UTC 2018
New revision: 469443
URL: https://svnweb.freebsd.org/changeset/ports/469443

Log:
  - Fix build when NLS is disabled by adding back required extra patch
  - While here, convert port to USES=localbase

  PR:		227326
  Submitted by:	guyyur@gmail.com
  Approved by:	portmgr blanket, Maintainer timeout

Changes:
  head/deskutils/parcellite/Makefile
  head/deskutils/parcellite/files/extrapatch-configure.ac
Comment 3 Guido Falsi freebsd_committer freebsd_triage 2018-05-09 10:51:00 UTC 
Committed. Thanks!