Bug 227375 - net-mgmt/klg: Fix build for PHP>=7
Summary: net-mgmt/klg: Fix build for PHP>=7
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Matthias Fechner
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2018-04-08 15:30 UTC by Daniel Austin
Modified: 2018-10-21 19:59 UTC (History)
2 users (show)

See Also:
freebsd-ports: maintainer-feedback+

Attachments
fix build on php7+, also dependancies on 5.6 (1.20 KB, patch)
2018-04-08 15:30 UTC, Daniel Austin 		freebsd-ports: maintainer-approval+
Details | Diff
also add php flavor support (1.34 KB, patch)
2018-04-08 17:52 UTC, Daniel Austin 		freebsd-ports: maintainer-approval+
Details | Diff
re-patch newer ports tree (1.32 KB, patch)
2018-10-20 18:01 UTC, Daniel Austin 		freebsd-ports: maintainer-approval+
Details | Diff
re-patch newer ports tree (1.32 KB, patch)
2018-10-20 18:02 UTC, Daniel Austin 		freebsd-ports: maintainer-approval+
Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Austin 2018-04-08 15:30:46 UTC 
Created attachment 192342 [details]
fix build on php7+, also dependancies on 5.6

Fix build on PHP 7+
Also fix dependancies on PHP 5.6 (mysqli not mysql for all PHP versions now)
Update Makefile to remove all portlint warnings

Poudriere testport logs for 10.4/11.1 i386/amd64 located at:

https://poudriere.dan.tm/poudriere/data/latest-per-pkg/klg/1.5_1/
Comment 1 Daniel Austin 2018-04-08 17:52:50 UTC 
Created attachment 192346 [details]
also add php flavor support

as per previous patch, but adds flavor support.

Poudriere testport logs at:

https://poudriere.dan.tm/poudriere/data/latest-per-pkg/klg-php56/1.5_1/
Comment 2 Matthias Fechner freebsd_committer freebsd_triage 2018-10-20 11:10:14 UTC 
Could you please update the patch, it fails to apply.
Comment 3 Daniel Austin 2018-10-20 18:01:06 UTC 
Created attachment 198408 [details]
re-patch newer ports tree

re-run patch so that it patches against current ports tree
Comment 4 Daniel Austin 2018-10-20 18:02:10 UTC 
Created attachment 198409 [details]
re-patch newer ports tree

re-patch against newer ports tree
Comment 5 Daniel Austin 2018-10-20 18:02:40 UTC 
(In reply to Matthias Fechner from comment #2)
this should apply against the latest ports tree now :)
Comment 6 commit-hook freebsd_committer freebsd_triage 2018-10-20 18:30:41 UTC 
A commit references this bug:

Author: mfechner
Date: Sat Oct 20 18:30:12 UTC 2018
New revision: 482613
URL: https://svnweb.freebsd.org/changeset/ports/482613

Log:
  Fix build on PHP 7+.
  Also fix dependancies on PHP 5.6 (mysqli not mysql for all PHP versions now).
  Update Makefile to remove all portlint warnings.
  Add flavour support.

  PR:		227375
  Submitted by:	freebsd-ports@dan.me.uk
  Reported by:	freebsd-ports@dan.me.uk
  Reviewed by:	mfechner@FreeBSD.org
  Approved by:	mentors (implicit)

Changes:
  head/net-mgmt/klg/Makefile
Comment 7 Matthias Fechner freebsd_committer freebsd_triage 2018-10-20 18:31:00 UTC 
Thanks!