Bug 227426 - [patch] net-mgmt/riemann: Update, unbreak IPv6 support and fix config + log location
Summary: [patch] net-mgmt/riemann: Update, unbreak IPv6 support and fix config + log l...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dave Cottlehuber
URL: https://reviews.freebsd.org/D16888
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-10 18:08 UTC by Romain Tartière
Modified: 2018-08-24 22:06 UTC (History)
3 users (show)

See Also:

Attachments
Fixes (1.21 KB, patch)
2018-04-10 18:08 UTC, Romain Tartière 		no flags Details | Diff
Update to latest release and fixes (1.96 KB, patch)
2018-05-30 09:04 UTC, Romain Tartière 		dch: maintainer-approval+
Details | Diff
more diffs (1.37 KB, patch)
2018-05-30 17:13 UTC, Dave Cottlehuber 		dch: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Romain Tartière freebsd_committer freebsd_triage 2018-04-10 18:08:11 UTC 
Created attachment 192399 [details]
Fixes

Dear maintainer,

Find attached a patch that fixes the rc.d script (%%ETCDIR%% is /usr/local/etc/riemann, so no need to add one more "riemann") and also set a correct default log file location (since your port already creates /var/log/riemann/ with proper permissions).

These changes require a PORTREVISION bump.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2018-04-10 18:08:11 UTC 
Maintainer informed via mail
Comment 2 Romain Tartière freebsd_committer freebsd_triage 2018-05-30 09:04:17 UTC 
Created attachment 193835 [details]
Update to latest release and fixes

Updated fix with update to the latest version and IPv6 fix.
Comment 3 Walter Schwarzenfeld 2018-05-30 09:48:35 UTC 
Trying to CC the maintainer ends up with
CC: 	dch@skunkwerks.at did not match anything.
Comment 4 Dave Cottlehuber freebsd_committer freebsd_triage 2018-05-30 17:13:34 UTC 
Created attachment 193845 [details]
more diffs

hi Romain

as mentioned on IRC +1 for committing your patch in preference to mine. I'm OOO for the next 10 days, so please go ahead without me.

Just if you can change the maintainer email to dch@FreeBSD.org on the way past, that would be great. I wonder if, when my BZ accounts were merged, if this somehow broke maintainer email?

BTW there is a reason for preferring IPv4 stack in Java, see https://github.com/riemann/riemann-dash/issues/11 for the background. It's pretty old now and it may be that the java dependencies in riemann have resolved this issue. I can't look into this until mid June, but the link above should help see if this is still necessary.
Comment 5 Dave Cottlehuber freebsd_committer freebsd_triage 2018-05-30 17:14:51 UTC 
Comment on attachment 193835 [details]
Update to latest release and fixes

approved, please check to see if the prefer ipv4 stack is still necessary, see URL in previous comment.
Comment 6 Dave Cottlehuber freebsd_committer freebsd_triage 2018-08-24 19:55:05 UTC 
see https://reviews.freebsd.org/D16888 for further review, patches imported as is.
Comment 7 commit-hook freebsd_committer freebsd_triage 2018-08-24 22:06:38 UTC 
A commit references this bug:

Author: dch
Date: Fri Aug 24 22:06:13 UTC 2018
New revision: 477983
URL: https://svnweb.freebsd.org/changeset/ports/477983

Log:
  net-mgmt/riemann: update 0.2.13 to 0.3.1

  - include fixes from romain@ for config file locations and remove IPv4
    stack specificity
  - amend LICENSE details for all jarfile components

  PR:		227426
  Submitted by:	romain
  Approved by:	jrm (mentor)
  Differential Revision:	https://reviews.freebsd.org/D16888

Changes:
  head/net-mgmt/riemann/Makefile
  head/net-mgmt/riemann/distinfo
  head/net-mgmt/riemann/files/riemann.in