Bug 227691 - r332821: broken build TRY_INP_WLOCK
Summary: r332821: broken build TRY_INP_WLOCK
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: 11.1-STABLE
Hardware: Any Any
: --- Affects Many People
Assignee: Jonathan T. Looney
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-22 10:57 UTC by Ivan Rozhuk
Modified: 2018-04-23 18:28 UTC (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ivan Rozhuk 2018-04-22 10:57:22 UTC 
/usr/src/sys/netinet/in_pcb.c:1812:12: error: implicit declaration of function 'TRY_INP_RLOCK' is invalid in C99 [-Werror,-Wimplicit-function-declaration]

# grep -R "TRY_INP_WLOCK" /usr/src/sys
/usr/src/sys/netinet/in_pcb.c:		locked = TRY_INP_WLOCK(inp);

# grep -R "TRY_INP_RLOCK" /usr/src/sys
/usr/src/sys/netinet/in_pcb.c:		locked = TRY_INP_RLOCK(inp);
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2018-04-22 16:32:27 UTC 
Over to committer of r332821.
Comment 2 Jonathan T. Looney freebsd_committer freebsd_triage 2018-04-23 14:19:03 UTC 
As the committer of r332821, I own this.

I ensured the code built when I committed it. However, I don't have the PCBGROUP option defined. The bad code is within that block. I'll MFC r331745, which should fix it.
Comment 3 commit-hook freebsd_committer freebsd_triage 2018-04-23 14:22:25 UTC 
A commit references this bug:

Author: jtl
Date: Mon Apr 23 14:22:16 UTC 2018
New revision: 332889
URL: https://svnweb.freebsd.org/changeset/base/332889

Log:
  MFC r331745 (by np):
    Fix RSS build (broken in r331309).

    Sponsored by: Chelsio Communications

  PR:		227691
  Pointy-hat to:	jtl

Changes:
_U  stable/11/
  stable/11/sys/netinet/in_pcb.c
Comment 4 Jonathan T. Looney freebsd_committer freebsd_triage 2018-04-23 14:22:58 UTC 
This should now be fixed.
Comment 5 Ivan Rozhuk 2018-04-23 18:28:30 UTC 
Yes, thanks.