Bug 227823 - [patch] [ocs_fc] the module ocs_fc(4) cannot be built outside of kernel build invironment
Summary: [patch] [ocs_fc] the module ocs_fc(4) cannot be built outside of kernel build...
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: 11.1-STABLE
Hardware: Any Any
: --- Affects Some People
Assignee: Ram Kishore Vegesna
URL:
Keywords: easy, patch-ready
Depends on:
Blocks:
 
Reported: 2018-04-28 03:57 UTC by Eugene Grosbein
Modified: 2018-05-22 10:25 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eugene Grosbein freebsd_committer freebsd_triage 2018-04-28 03:57:12 UTC 
In file included from /usr/local/src/sys/dev/ocs_fc/ocs_pci.c:41:
In file included from /usr/local/src/sys/dev/ocs_fc/ocs.h:43:
/usr/local/src/sys/dev/ocs_fc/ocs_os.h:45:10: fatal error: 'opt_stack.h' file not found
#include "opt_stack.h"
         ^~~~~~~~~~~~~
1 error generated.
*** Error code 1

The fix is simple:

--- Makefile.orig       2018-04-27 15:51:14.589172000 +0000
+++ Makefile    2018-04-28 03:49:51.586046000 +0000
@@ -6,10 +6,11 @@
 SRCS = \
        device_if.h \
        bus_if.h \
        pci_if.h \
        opt_scsi.h \
+       opt_stack.h \
        opt_cam.h

 # OS
 SRCS += ocs_pci.c ocs_ioctl.c ocs_os.c ocs_utils.c
Comment 1 Kenneth D. Merry freebsd_committer freebsd_triage 2018-04-28 03:59:28 UTC 
Passing this over to Ram, he maintains the driver for Broadcom and is now a committer.
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-04-30 07:24:38 UTC 
A commit references this bug:

Author: ram
Date: Mon Apr 30 07:24:31 UTC 2018
New revision: 333099
URL: https://svnweb.freebsd.org/changeset/base/333099

Log:
  Included opt_stack.h in Makefile, to fix module build.

  PR: 227823
  Reported by: eugen
  Approved by: mav
  MFC after: 3 days

Changes:
  head/sys/modules/ocs_fc/Makefile
Comment 3 commit-hook freebsd_committer freebsd_triage 2018-05-22 10:23:42 UTC 
A commit references this bug:

Author: ram
Date: Tue May 22 10:23:12 UTC 2018
New revision: 334029
URL: https://svnweb.freebsd.org/changeset/base/334029

Log:
  MFC r333099: Included opt_stack.h in Makefile, to fix module build outside kernel build environment.

  PR: 227823
  Reported by: eugen
  Approved by: re

Changes:
_U  stable/11/
  stable/11/sys/modules/ocs_fc/Makefile