Created attachment 192904 [details] dehydrated v0.6.2 patch The following patch updates dehydrated to v0.6.2 poudriere testport (amd64) -> ok
Committed with changes. Thank you for the update!
A commit references this bug: Author: yuri Date: Sun Apr 29 22:43:48 UTC 2018 New revision: 468668 URL: https://svnweb.freebsd.org/changeset/ports/468668 Log: security/dehydrated: Update 0.6.1-7 -> 0.6.2 Port changes: * Add bash to RUN_DEPENDS * Remove BASH and ZSH options as per PHB * Change PORTDOCS to * for simplicity * Silence some commands PR: 227848 Submitted by: Sascha Holzleiter <sascha@root-login.org> (maintainer) Changes: head/security/dehydrated/Makefile head/security/dehydrated/distinfo
I get the PORTDOCS changes, thanks for that! But why where the OPTIONS removed? I get that the PHB recommends not defining OPTIONS merely for the installation of completion files. But the OPTIONS were used to actually change the ports dependency on bash or zsh which is intentional!
(In reply to Sascha Holzleiter from comment #3) > But why where the OPTIONS removed? I get that the PHB recommends not defining OPTIONS merely for the installation of completion files. But the OPTIONS were used to actually change the ports dependency on bash or zsh which is intentional! Ports shouldn't add dependencies just for completions to run. The new policy is that completion files are always installed unconditionally, and they will work when corresponding shells are installed. But ports shouldn't install shells themselves. Hope this helps! Yuri
As stated in my last comment i understand that. This port used them for something else! This port changed the installed scripts to use the chosen shell so you do not need to install another shell just because of this port. If you were a bash user you could just leave the defaults and the script and port would depend on the shell your are already using. If you were a zsh user you could use the ZSH option so the script and the port only depended on zsh and there was no need to install bash. The options took care of rewriting the she-bang lines in the installed scripts to the shell of your choice and registering the correct dependency.
(In reply to Sascha Holzleiter from comment #5) I see. Sorry about this. I will correct it.
A commit references this bug: Author: yuri Date: Mon Apr 30 01:49:56 UTC 2018 New revision: 468669 URL: https://svnweb.freebsd.org/changeset/ports/468669 Log: security/dehydrated: Restore ZSH and BASH options because they make scripts to use these shells The options were deleted mistakenly in the previous commit. Additionally, moved plist into pkg-plist file, and added @sample instructions for relevant samples. PR: 227848 Reported by: Sascha Holzleiter <sascha@root-login.org> (maintainer) Changes: head/security/dehydrated/Makefile head/security/dehydrated/pkg-plist
Restored the options.
A commit references this bug: Author: koobs Date: Mon Jul 1 13:54:59 UTC 2019 New revision: 505573 URL: https://svnweb.freebsd.org/changeset/ports/505573 Log: MFH: r468669 r505499 r505571 security/dehydrated: Restore ZSH and BASH options because they make scripts to use these shells The options were deleted mistakenly in the previous commit. Additionally, moved plist into pkg-plist file, and added @sample instructions for relevant samples. PR: 227848 Reported by: Sascha Holzleiter <sascha@root-login.org> (maintainer) security/dehydrated: update to 0.6.4 PR: 238820 Submitted by: Sascha Holzleiter <sascha@root-login.org> (maintainer) security/dehydrated: Update to 0.6.5 While I'm here, pet portlint: WARN: Makefile: extra item placed in the USES/USE_x section, for example, "NO_BUILD". Changelog: https://github.com/lukas2511/dehydrated/blob/v0.6.5/CHANGELOG PR: 238918 Submitted by: Sascha Holzleiter <sascha root-login org> (maintainer) Approved by: ports-secteam (blanket: bugfix release(s)) Changes: _U branches/2019Q2/ branches/2019Q2/security/dehydrated/Makefile branches/2019Q2/security/dehydrated/distinfo