Bug 227851 - lang/ruby24 fails to build with libressl-2.7.2_1
Summary: lang/ruby24 fails to build with libressl-2.7.2_1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-29 14:36 UTC by Walter Schwarzenfeld
Modified: 2018-06-05 19:02 UTC (History)
10 users (show)

See Also:
bugzilla: maintainer-feedback? (ruby)


Attachments
ruby24-build.log (116.04 KB, text/plain)
2018-04-29 14:36 UTC, Walter Schwarzenfeld
no flags Details
Fix building against LibreSSL >= 2.7.0 (1.21 KB, patch)
2018-05-16 15:11 UTC, Ralf van der Enden
tremere: maintainer-approval?
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Walter Schwarzenfeld freebsd_triage 2018-04-29 14:36:32 UTC
Created attachment 192907 [details]
ruby24-build.log

ruby24 fails to build with libressl-2.7.2_1.
Attached build.log.
Comment 1 Walter Schwarzenfeld freebsd_triage 2018-04-29 16:17:35 UTC
The patch for ruby25 in Bug #226852  solves it also for ruby24.
Comment 2 oz42 2018-05-04 12:07:34 UTC
Thanks for the patch, ot worked.
Comment 3 Ralf van der Enden 2018-05-16 15:00:42 UTC
I found the following patch which works fine (and should also work for 2.5):

https://github.com/ruby/openssl/issues/192

Looks like an easier way to fix things than the patches in #226852
Comment 4 Ralf van der Enden 2018-05-16 15:11:50 UTC
Created attachment 193461 [details]
Fix building against LibreSSL >= 2.7.0
Comment 5 Kirill Ponomarev freebsd_committer freebsd_triage 2018-05-24 21:19:57 UTC
ruby@ guys, please review it, otherwise I'm going to commit it
Comment 6 Walter Schwarzenfeld freebsd_triage 2018-05-24 22:09:41 UTC
Patch works for me.
Comment 7 Romain Tartière freebsd_committer freebsd_triage 2018-05-24 22:15:06 UTC
I also use it without problem so far.
Comment 8 Thibault Jouan 2018-05-27 13:04:22 UTC
Works for me too with both ssl=openssl and ssl=libressl-devel.
Comment 9 commit-hook freebsd_committer freebsd_triage 2018-06-05 18:58:24 UTC
A commit references this bug:

Author: sunpoet
Date: Tue Jun  5 18:57:28 UTC 2018
New revision: 471799
URL: https://svnweb.freebsd.org/changeset/ports/471799

Log:
  Fix build with LibreSSL 2.7

  Obtained from:	https://github.com/ruby/openssl/commit/75de15ddcdab6efe7faf3ca1f6b5c6e5b6ba57cc
  PR:		227851

Changes:
  head/lang/ruby24/files/patch-ext-openssl-extconf.rb
Comment 10 Po-Chuan Hsieh freebsd_committer freebsd_triage 2018-06-05 19:02:53 UTC
Committed. Thanks!