Bug 228176 - textproc/tkdiff: improve the port, and take MAINTAINERship
Summary: textproc/tkdiff: improve the port, and take MAINTAINERship
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Fernando Apesteguía
URL:
Keywords: easy, patch, patch-ready
Depends on:
Blocks:
 
Reported: 2018-05-11 22:34 UTC by Chris Hutchinson
Modified: 2018-05-24 05:14 UTC (History)
1 user (show)

See Also:

Attachments
svn diff for textproc/tkdiff (88.48 KB, patch)
2018-05-11 22:34 UTC, Chris Hutchinson 		no flags Details | Diff
QA LOG for textproc/tkdiff (4.88 KB, text/plain)
2018-05-11 22:36 UTC, Chris Hutchinson 		no flags Details
version 2 (superceeds previously submitted patch) (88.46 KB, patch)
2018-05-21 17:14 UTC, Chris Hutchinson 		portmaster: maintainer-approval+
Details | Diff
version 3 (superceeds previously submitted patch) (88.63 KB, patch)
2018-05-22 15:52 UTC, Chris Hutchinson 		portmaster: maintainer-approval+
Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Hutchinson 2018-05-11 22:34:20 UTC 
Created attachment 193299 [details]
svn diff for textproc/tkdiff

I was working on a pr(1), and needed something like this,
so I built it, and noticed it could be improved, and
had no maintainer. So while already here, I made some
changes, and added myself as MAINTAINER. :-)

CHANGES
 o add DESKTOP_ENTRY
 o add converters/base64 as BUILD_DEPENDS
 o add icons
 o take MAINTAINER

the addition of the BUILD_DEPENDS was because it seems
far more portable distributing icons as base64 packed
files in the ports files/ folder. Further; I'm pretty
sure that anyone with a mail client already has base64
installed, anyway. :-)

See the attached svn diff for greater detail.

That's it!

Thanks!

--Chris
Comment 1 Chris Hutchinson 2018-05-11 22:36:00 UTC 
Created attachment 193300 [details]
QA LOG for textproc/tkdiff

Proves it builds, and installs as expected,
and that the ports framework has no complaints. :-)
Comment 2 Fernando Apesteguía freebsd_committer freebsd_triage 2018-05-15 20:42:24 UTC 
Take
Comment 3 Fernando Apesteguía freebsd_committer freebsd_triage 2018-05-20 18:34:55 UTC 
Hi Chris,

Thanks for the patch. The QA looks good and portlint output is clean. However, the handling of the icons did not pass my mentor's bar :)

Any chances of changing the format?

Here is the review I created:

https://reviews.freebsd.org/D15480
Comment 4 Chris Hutchinson 2018-05-21 17:14:48 UTC 
Created attachment 193593 [details]
version 2 (superceeds previously submitted patch)

Updated version incorporating change suggested
by Mat in review D15480

Thanks!

--Chris
Comment 5 Chris Hutchinson 2018-05-22 15:52:54 UTC 
Created attachment 193615 [details]
version 3 (superceeds previously submitted patch)

OK this update simply renames the files in ${FILESDIR}
as requested by @tcberner
Please see review #D15509 for further detail(s).

--Chris
Comment 6 commit-hook freebsd_committer freebsd_triage 2018-05-23 22:00:37 UTC 
A commit references this bug:

Author: fernape
Date: Wed May 23 21:59:35 UTC 2018
New revision: 470725
URL: https://svnweb.freebsd.org/changeset/ports/470725

Log:
  textproc/tkdiff: port improvements

  * add DESKTOP_ENTRY
  * add converters/base64 as BUILD_DEPENDS
  * add icons

  Also give maintainership to portmaster@bsdforge.com

  PR:	228176
  Submitted by:	portmaster@bsdforge.com
  Approved by:	tcberner (mentor)
  Differential Revision:	https://reviews.freebsd.org/D15480

Changes:
  head/textproc/tkdiff/Makefile
  head/textproc/tkdiff/files/
  head/textproc/tkdiff/files/icon128.base64
  head/textproc/tkdiff/files/icon256.base64
  head/textproc/tkdiff/files/icon32.base64
  head/textproc/tkdiff/files/icon64.base64
Comment 7 Fernando Apesteguía freebsd_committer freebsd_triage 2018-05-23 22:01:35 UTC 
Committed,

Thanks Chris for your work, rework and for your patience :)
Comment 8 Chris Hutchinson 2018-05-24 05:14:13 UTC 
(In reply to Fernando Apesteguía from comment #7)
> Committed,
> 
> Thanks Chris for your work, rework and for your patience :)

...and Thank *you*, Fernando! :-)

--Chris