Bug 228362 - devel/subversion: Update "Sponsored by" microcopy in FBSD extra patch
Summary: devel/subversion: Update "Sponsored by" microcopy in FBSD extra patch
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Lev A. Serebryakov
URL:
Keywords:
Depends on: 228353
Blocks:
  Show dependency tree / graph
 
Reported: 2018-05-19 14:24 UTC by John W. O'Brien
Modified: 2018-10-10 15:42 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (lev)

Attachments
devel/subversion: Update "Sponsored by" microcopy (1.62 KB, text/plain)
2018-05-19 14:24 UTC, John W. O'Brien 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John W. O'Brien 2018-05-19 14:24:27 UTC 
Created attachment 193534 [details]
devel/subversion: Update "Sponsored by" microcopy

The attached patch aims to add a gentle hint to the committer to avoid crediting, or giving the impression of crediting, their own sponsor for the work of one or more collaborators. This improvement is also the topic of doc bug 228353.

I welcome feedback on how to improve this patch to optimize for the most effective reminder/prompt in minimum words. The expectation is that someone committing a patch that is entirely their own creation would do nothing differently, but that someone committing the product of a collaboration would amend the "Sponsored by" line to more precisely and equitably assign credit. See the description and patch of bug 228353 for details.
Comment 1 John W. O'Brien 2018-05-19 14:27:20 UTC 
I'm adding bug 228353 as a blocker because the improved standard should be accepted and documented before finalizing how it should be reflected in the SVN template, if at all.
Comment 2 John W. O'Brien 2018-08-06 23:18:10 UTC 
Now that bug 228353 has been resolved, I would appreciate feedback on my proposed patch. Is there a better way to improve the hint?
Comment 3 commit-hook freebsd_committer freebsd_triage 2018-10-10 15:40:41 UTC 
A commit references this bug:

Author: lev
Date: Wed Oct 10 15:39:54 UTC 2018
New revision: 481744
URL: https://svnweb.freebsd.org/changeset/ports/481744

Log:
   (1) Update to 1.10.3.
   (2) Fix STATIC build.
   (3) Expand FreeBSD template for better explanation of "Sponsored by"

  PR:		(2) 220660, (3) 228362

Changes:
  head/devel/p5-subversion/Makefile
  head/devel/py-subversion/Makefile
  head/devel/ruby-subversion/Makefile
  head/devel/subversion/Makefile
  head/devel/subversion/Makefile.common
  head/devel/subversion/distinfo
  head/devel/subversion/files/extra-patch-fbsd-template
  head/devel/subversion/files/patch-subversion-libsvn_client-conflicts.c
  head/java/java-subversion/Makefile
  head/security/subversion-gnome-keyring/Makefile
  head/security/subversion-kwallet/Makefile
  head/www/mod_dav_svn/Makefile
Comment 4 Lev A. Serebryakov freebsd_committer freebsd_triage 2018-10-10 15:42:24 UTC 
Commited, thnx!