Bug 228718 - [exp-run] drop MOUSE_GETVARS and MOUSE_SETVARS ioctls support.
Summary: [exp-run] drop MOUSE_GETVARS and MOUSE_SETVARS ioctls support.
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: Vladimir Kondratyev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-03 08:51 UTC by Vladimir Kondratyev
Modified: 2018-06-10 10:31 UTC (History)
1 user (show)

See Also:
antoine: exp-run+

Attachments
MOUSE_GETVARS.patch (6.30 KB, patch)
2018-06-03 08:51 UTC, Vladimir Kondratyev 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Kondratyev freebsd_committer freebsd_triage 2018-06-03 08:51:02 UTC 
Created attachment 193961 [details]
MOUSE_GETVARS.patch

sys/mouse.h header has a definition of MOUSE_GETVARS and MOUSE_SETVARS ioctls which are not documented and only stubbed in a few drivers: mse(4), psm(4) and syscon's sysmouse(4). The only exception is MOUSE_GETVARS implemented in psm(4)

Given the fact that they were introduced 20 years ago and implementation has never been completed, remove any related code.
Comment 1 Antoine Brodin freebsd_committer freebsd_triage 2018-06-06 05:46:14 UTC 
Exp-run looks fine.
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-06-10 10:24:23 UTC 
A commit references this bug:

Author: wulf
Date: Sun Jun 10 10:23:33 UTC 2018
New revision: 334923
URL: https://svnweb.freebsd.org/changeset/base/334923

Log:
  Drop MOUSE_GETVARS and MOUSE_SETVARS ioctls support.

  These ioctls are not documented and only stubbed in a few drivers: mse(4),
  psm(4) and syscon's sysmouse(4). The only exception is MOUSE_GETVARS
  implemented in psm(4)

  Given the fact that they were introduced 20 years ago and implementation
  has never been completed, remove any related code.

  PR:		228718 (exp-run)
  Reviewed by:	imp
  Differential Revision:	https://reviews.freebsd.org/D15726

Changes:
  head/share/man/man4/man4.i386/mse.4
  head/share/man/man4/mouse.4
  head/share/man/man4/psm.4
  head/share/man/man4/sysmouse.4
  head/sys/dev/atkbdc/psm.c
  head/sys/dev/mse/mse.c
  head/sys/dev/syscons/sysmouse.c
  head/sys/sys/mouse.h