Created attachment 194042 [details] storcli-007.0504.0000.0000.patch Upstream update 007.0504.0000.0000
Take
Hi, It does not fetch for me. I get this: ===> License storcli accepted by the user ===> storcli-007.0504.0000.0000 depends on file: /usr/local/sbin/pkg - found => 007.0504.0000.0000_Unified_StorCLI.zip doesn't seem to exist in /usr/home/fernape/FreeBSD-repos/ports/head/distfiles/. => Attempting to fetch https://docs.broadcom.com/docs-and-downloads/docs-and-downloads/raid-controllers/007.0504.0000.0000_Unified_StorCLI.zip fetch: https://docs.broadcom.com/docs-and-downloads/docs-and-downloads/raid-controllers/007.0504.0000.0000_Unified_StorCLI.zip: Forbidden I tried to fetch the file manually by navigating the URL with no luck. Any ideas?
(In reply to Fernando Apesteguía from comment #2) It is necessary to activate the web page and download the distribution file at hand. Therefore, it should not be in an environment where you can download directly. But technically, by placing a copy on LOCAL/je3kmz, I will solve what you say.
(In reply to takefu from comment #3) I don't fully understand what you mean about activating the web page. If the port needs manual fetching, it needs to specify the exact steps to get the distfile. Can you have a look at how is this handled in java/linux-oracle-jdk[1] [1] https://svnweb.freebsd.org/ports/head/java/linux-oracle-jdk18/Makefile?view=markup&pathrev=470939#l67
Created attachment 194070 [details] Proposed patch This patch includes a message indicating how to manually download the distfile.
Does the attached patch seem reasonable?
Created attachment 194076 [details] storcli-007.0504.0000.0000_2.patch The attached patch is reasonable. However, I fixed it a bit.
Off-topic: Who invents such "monstrous" version-numbers?
(In reply to w.schwarzenfeld from comment #8) I do not know. :/
(In reply to takefu from comment #3) > But technically, by placing a copy on LOCAL/je3kmz, I will solve what you > say. Did you check that redistribution of the distfile is allowed?
(In reply to Mathieu Arnold from comment #10) It seems to be permited. From ${WRKDIR}/storcli-007.0504.0000.0000/Unified_storcli_all_os/FreeBSD/license.txt * Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following disclaimer in the documentation and/or other materials provided with the distribution. However, I don't know if we want to house distfiles just because they need manual fetch intervention. We don't do this in other places (like java/linux-oracle-jdk). When downloading from https://docs.broadcom.com/docs... we must explicitly accept the license note. I think this should be sufficient reason to avoid having the distfile in LOCAL/
Created attachment 194148 [details] storcli-007.0504.0000.0000_3.patch Fixed to allow fetch automatically. I don't think the license issue has been resolved yet. You need to have an explicit license display and consent before downloading for resolution, right?
(In reply to takefu from comment #12) Hi again, I truly think we should not download the file even if we _can_ access the URL for the distfile. In the pop-up window that shows up when accessing via web, there is this very first paragraph: BY OPENING THE SOFTWARE PACKAGE, CLICKING ON THE "ACCEPT" BUTTON OF ANY ELECTRONIC VERSION OF THIS AGREEMENT OR ACCESSING OR INSTALLING THE SOFTWARE, YOU ACKNOWLEDGE THAT YOU HAVE READ THE AGREEMENT, UNDERSTAND IT AND AGREE TO BE BOUND BY ITS TERMS AND CONDITIONS. IF YOU DO NOT AGREE TO THE TERMS OF THIS AGREEMENT, DO NOT DOWNLOAD, INSTALL, COPY OR USE THE SOFTWARE. I would pay special attention to the last sentence. I am not a lawyer, but as a precaution, I think we should go with the manual fetching. Would you agree?
(In reply to Fernando Apesteguía from comment #13) I agree.
A commit references this bug: Author: fernape Date: Fri Jun 22 15:37:13 UTC 2018 New revision: 473045 URL: https://svnweb.freebsd.org/changeset/ports/473045 Log: sysutils/storcli: Update to 7.5 Distfile needs to be downloaded manually after accepting the license terms. PR: 228777 Reported by: takefu@airport.fm (maintainer) Approved by: tcberner (mentor) Differential Revision: https://reviews.freebsd.org/D15779 Changes: head/sysutils/storcli/Makefile head/sysutils/storcli/distinfo
Committed, Sorry for the wait. Thanks!